Always use CPU usage information if available. #4821
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past you could use the timelineType parameter to turn this off (and draw the graph as if CPU usage was 100% all the time) but this capability is no longer useful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4821 +/- ##
==========================================
- Coverage 88.28% 88.28% -0.01%
==========================================
Files 301 301
Lines 26921 26920 -1
Branches 7276 7274 -2
==========================================
- Hits 23767 23766 -1
Misses 2936 2936
Partials 218 218 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use
?timelineType=categoryin the URL in order to pick the CPU-unaware activity graph even for profiles which include CPU usage information. This causes us to draw the graph as if CPU usage was 100% all the time.I think this ability to switch between CPU activity graph and no-CPU activity graph is no longer useful. It is time to simplify some code.
@canova Thoughts?
Example profiles (all links go to current production):
We can make some simplifications to
determineTimelineTypeas a result. I'll keep this PR as a draft until I've looked at those in more detail. We may also want a URL upgrader, but I'm not sure if that's valuable.┆Issue is synchronized with this Jira Task