[deploy preview] Experimental UI for flows #5190
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5190 +/- ##
==========================================
- Coverage 88.57% 87.60% -0.97%
==========================================
Files 308 309 +1
Lines 28028 28352 +324
Branches 7587 7658 +71
==========================================
+ Hits 24826 24839 +13
- Misses 2985 3245 +260
- Partials 217 268 +51 ☔ View full report in Codecov by Sentry. |
mstange
force-pushed
the
get-flows
branch
4 times, most recently
from
8ccc7a6
to
def0728
Compare
This changeset changes the type definition for marker schema field types and for the marker schema itself, to include the new field types 'flow-id' and 'terminating-flow-id'. It also has some minimal changes to treat the new field types as if they were unique-string fields. Somewhat unrelated to flows, it also adds an optional `isStackBased` field to the marker schema type, which is currently unused. This is for firefox-devtools#3141 . Additionally, it increments the version of the two profile formats, so that profiles with the new field types won't be loaded by older front-ends.
mstange
force-pushed
the
get-flows
branch
2 times, most recently
from
b42888f
to
127fa1b
Compare
mstange
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy preview
Fixes #5178, to a degree.
This adds a flow panel at the bottom of the marker chart.
The panel shows a row per flow once a marker with flow fields is clicked. Clicking a row in the panel makes that flow the active flow and shows its associated flows in the panel. Hovering markers in the flow panel shows a tooltip and arrows.
This PR also adds the following functions that can be called from the console:
printFlows()printFlow(1234)(called with flow indexes, for example those from the "incoming context flows" printed byprintFlows())selectMarkerOnThread(1234, 56)(called with the marker index and the thread index)Those aren't that useful anymore; we used them before this PR had any UI.