Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to show equal widths stacks in the stack chart #5195

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

julienw
Copy link
Contributor

@julienw julienw commented Nov 8, 2024

By no means this is ready.

Not working:

  • preview selection
  • hit testing (so tooltips)

But I wanted to give you a sneak peek :-)

deploy preview

@julienw julienw requested a review from a team as a code owner November 8, 2024 17:05
@@ -792,6 +792,7 @@ StackSettings--call-tree-strategy-native-deallocations-sites = Deallocation Site
StackSettings--invert-call-stack = Invert call stack
.title = Sort by the time spent in a call node, ignoring its children.
StackSettings--show-user-timing = Show user timing
StackSettings--use-stack-chart-equal-widths = Use an equal width for each stack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
StackSettings--use-stack-chart-equal-widths = Use an equal width for each stack
StackSettings--use-stack-chart-equal-widths = Use the same width for each stack

Would it be clearer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah that's much better, thanks

@julienw julienw marked this pull request as draft November 18, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants