Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support importing simpleperf trace files from Android Studio #5212

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nisargjhaveri
Copy link
Contributor

Fix #5203.

Attempt to add importer for simpleperf trace files. These can be generated using the simpleperf report-sample command or using Profiler UI in Android Studio.

Here is the file format details: https://cs.android.com/android/platform/superproject/main/+/main:system/extras/simpleperf/cmd_report_sample.proto

Added a couple of dependencies to work with protobuf. These will also be useful for more importers in future, I believe pprof also uses protobufs (in discussion at #4462).

This is one attempt. I'm fairly new to the codebase and Flow. Feel free to suggest any changes as required.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 6.56371% with 242 lines in your changes missing coverage. Please review.

Project coverage is 84.68%. Comparing base (28e880e) to head (5f4217d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/profile-logic/import/simpleperf.js 6.22% 212 Missing and 29 partials ⚠️
src/profile-logic/process-profile.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5212      +/-   ##
==========================================
- Coverage   88.61%   84.68%   -3.94%     
==========================================
  Files         308      310       +2     
  Lines       28051    29576    +1525     
  Branches     7596     8156     +560     
==========================================
+ Hits        24858    25047     +189     
- Misses       2979     3884     +905     
- Partials      214      645     +431     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support importing simpleperf trace files from Android Studio
1 participant