Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support absolute memory counters #5216

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PaulBone
Copy link
Contributor

@PaulBone PaulBone commented Nov 20, 2024

Support absolute in addition to relative memory counters and render them correctly. This involves incrementing the profiler versions.

The corresponding gecko code change is 1806054 (https://bugzilla.mozilla.org/show_bug.cgi?id=1806054): Memory profiling uses the expensive malloc_usable_size function.

Support absolute in addition to relative memory counters and render them
correctly.  This involves incrementing the profiler versions.
@PaulBone
Copy link
Contributor Author

This pull request is a draft. I still have to:

  • Fix a problem with relative markers, their tooltips are broken.
  • Try to load old profiles from the processed format.
  • Try to load old profiles from the gecko format.
  • Write more tests.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 84.52381% with 13 lines in your changes missing coverage. Please review.

Project coverage is 88.57%. Comparing base (8764e83) to head (bf0d6e8).

Files with missing lines Patch % Lines
src/profile-logic/process-profile.js 65.00% 6 Missing and 1 partial ⚠️
src/components/timeline/TrackMemoryGraph.js 76.47% 4 Missing ⚠️
src/components/timeline/TrackBandwidthGraph.js 83.33% 1 Missing ⚠️
src/test/fixtures/profiles/processed-profile.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5216      +/-   ##
==========================================
- Coverage   88.62%   88.57%   -0.05%     
==========================================
  Files         308      308              
  Lines       28059    28104      +45     
  Branches     7598     7625      +27     
==========================================
+ Hits        24867    24894      +27     
- Misses       2978     2995      +17     
- Partials      214      215       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant