Audit fixes #3
Merged
Audit fixes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erhant
requested changes
Dec 2, 2024
erhant
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audit Fixes
Resolves M-04: Users can list assets with price < 1 ERC20 (ETH, WETH), leading to potential DoS vulnerability. #4
Added
minAssetPricehttps://github.com/firstbatchxyz/swan-contracts/blob/caglacelik/audit-fixes/src/Swan.sol#L213
Resolves M-07: Phase calculation inaccuracy will always extend sell phase and cut withdrawal phase time #5
https://github.com/firstbatchxyz/swan-contracts/blob/caglacelik/audit-fixes/src/BuyerAgent.sol#L321
Resolves L-02: Sequential Fee Calculations Lead to Lost Platform Revenue Due to Precision Loss #6
Used 10_000 instead of 100 and Openzeppelin' Math library
https://github.com/firstbatchxyz/swan-contracts/blob/caglacelik/audit-fixes/src/Swan.sol#L310
Resolves L-04: Ownership transfer grants former Swan contract owner continued operator privileges #7
Override
transferOwnership()https://github.com/firstbatchxyz/swan-contracts/blob/caglacelik/audit-fixes/src/Swan.sol#L164
Added events to
BuyerAgentUpdate docs & tests
Fuzz + Invariant tests
Curr Coverages (with Invariant Tests)
Not necessary to fixed due to design choices
H0-1: Listing clone nfts
L-05: Insufficient Validation of Token Name and Symbol in list function