Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Updated README with note section regarding the avoidance of edi… #70213

Closed

Conversation

Esh07
Copy link
Contributor

@Esh07 Esh07 commented Jul 18, 2023

…ting multiple lines

In "Making necessary changes," I added a note stating not to make multiple changes in the file and provided a link to the "Design decisions for the tutorials "

@Roshanjossey, what are your thought on these changes?

…ting multiple lines

In "Making necessary changes," I added a note stating not to make multiple changes in the file and provided a link to the "Design decisions for the tutorials "
@Jcolebeyond02
Copy link

Jcolebeyond02 commented Jul 19, 2023

I'm having problems with the pull request I still haven't been able to accomplish a pull request is it possible for me to get some assistance on pulling request ID really APPERICATE it if so my name is Jennifer Jackson and email is *** and number is *** thanks

@Esh07
Copy link
Contributor Author

Esh07 commented Jul 19, 2023

I'm having problems with the pull request I still haven't been able to accomplish a pull request is it possible for me to get some assistance on pulling request ID really APPERICATE it if so my name is Jennifer Jackson and email is **** and number is ****** thanks

Hey @Jcolebeyond02, welcome to your first contribution!

Don't worry, I've got you covered. We have a section in the documentation with straightforward and easy-to-follow steps to help you get started with your pull request.

Just follow the tutorial located here.

If you find any difficulties or get stuck at any point, feel free to reach out to me. I'm here to help.

:IMPORTANT : 🚨 Please DO NOT share personal information in any open/public source

happy coding.

@Roshanjossey
Copy link
Member

@Jcolebeyond02, I want to reiterate what @Esh07 mentioned. Don't share your personal info. I've updated your comment to remove it.

In terms of getting help try the following

  1. Ask our slack community. Explain the problem you're facing rather than saying you have a problem.
  2. Check FAQ / Common errors and how to resolve them. #30831 it might have a solution.
  3. Create a new issue explaining the problem.

@@ -134,6 +134,7 @@ For example:
git switch -c add-alonzo-church
```
## Make necessary changes and commit those changes
> **Important**: Please DO NOT change multiple lines. Here's why - [read the 3rd bullet point](https://github.com/firstcontributions/first-contributions/issues/35892#issue-778716847).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not add another note to the Readme that's specific about our project. I think it's better handled with checks in merge script.

@Esh07 Esh07 deleted the Esh07/update-readme-file branch August 12, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants