chore: add pre-commit hook and fix prettier/eslint config #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crish15
approved these changes
Nov 11, 2024
oxcened
suggested changes
Nov 11, 2024
apps/storybook/package.json
Outdated
| @@ -53,6 +54,7 @@ | |||
| "@fiscozen/typeahead": "workspace:^", | |||
| "@fiscozen/upload": "workspace:^", | |||
| "@fiscozen/view-flag": "workspace:^", | |||
| "stylelint": "^16.10.0", | |||
There was a problem hiding this comment.
should be a dev dependency, this applies to all packages
oxcened
reviewed
Nov 28, 2024
| "author": "Alen Ajam", | ||
| "dependencies": { | ||
| "@fiscozen/navlink": "workspace:^", | ||
| "stylelint": "^16.10.0" |
There was a problem hiding this comment.
reminder that stylelint should be a dev dependency in all packages
oxcened
reviewed
Nov 28, 2024
| "nx": "17.2.8", | ||
| "plop": "^4.0.1", | ||
| "vitest": "^1.0.4" | ||
| }, | ||
| "dependencies": { | ||
| "lint-staged": "^15.2.10" |
There was a problem hiding this comment.
I would make this a dev one as well
chore(prettier): update prettier config chore: add husky config chore: fix prettier and eslint config chore: add precommit hook chore(stylelint-config): add stylelint config fix: fix script config chore: add stylelint config chore(LIB-353): revert lint-staged checks fix: fix storybook deps chore: add vue-tsc step
panicofr
force-pushed
the
LIB-353-precommit-hooks
branch
from
9268c63 to
975cc4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pre-commit hook that run eslint and prettier on staged files.
TODO:
add tsc to the toolchain to validate TS typingadd stylelint to check style blocks