test(e2e): improve validation fro name query param

fityannugroho · Feb 11, 2024 · 42b8dc0 · 42b8dc0
1 parent 02853ca
commit 42b8dc0
Show file tree

Hide file tree

Showing 6 changed files with 47 additions and 7 deletions.
diff --git a/test/district.e2e-spec.ts b/test/district.e2e-spec.ts
@@ -1,6 +1,7 @@
 import { District } from '@prisma/client';
 import { AppTester } from './helper/app-tester';
 import { districtRegex } from './helper/data-regex';
+import { getEncodedSymbols } from './helper/utils';
 
 describe('District (e2e)', () => {
   const baseUrl = '/districts';
@@ -27,7 +28,10 @@ describe('District (e2e)', () => {
     });
 
     it("should return 400 if the `name` is more than 100 chars, or contains any other symbols besides '()-./", async () => {
-      const invalidNames = ['x'.repeat(101), 'b@ndung'];
+      const invalidNames = [
+        'x'.repeat(101),
+        ...getEncodedSymbols({ exclude: '()-./' }),
+      ];
 
       for (const name of invalidNames) {
         await tester.expectBadRequest(`${baseUrl}?name=${name}`);

diff --git a/test/helper/utils.ts b/test/helper/utils.ts
@@ -0,0 +1,26 @@
+/**
+ * All symbol characters.
+ */
+const symbols = '`~!@#$%^&*()_+-=[]{}|;:,.<>?/\\';
+
+type GetEncodedSymbolsOptions = {
+  /**
+   * The symbol characters to exclude.
+   */
+  exclude?: string;
+};
+
+/**
+ * Get encoded symbol characters.
+ * @returns The encoded symbol characters.
+ */
+export function getEncodedSymbols(
+  options: GetEncodedSymbolsOptions = {},
+): string[] {
+  const { exclude = '' } = options;
+
+  return symbols
+    .split('')
+    .filter((char) => !exclude.includes(char))
+    .map((char) => encodeURIComponent(char));
+}
diff --git a/test/island.e2e-spec.ts b/test/island.e2e-spec.ts
@@ -1,6 +1,7 @@
 import { Island } from '@prisma/client';
 import { AppTester } from './helper/app-tester';
 import { islandRegex } from './helper/data-regex';
+import { getEncodedSymbols } from './helper/utils';
 
 describe('Island (e2e)', () => {
   const baseUrl = '/islands';
@@ -31,8 +32,11 @@ describe('Island (e2e)', () => {
       });
     });
 
-    it('should return 400 if the `name` is more than 100 chars, or contains any symbols', async () => {
-      const invalidNames = ['x'.repeat(101), 's@bang'];
+    it("should return 400 if the `name` is more than 100 chars, or contains any symbols except '-/", async () => {
+      const invalidNames = [
+        'x'.repeat(101),
+        ...getEncodedSymbols({ exclude: "'-/" }),
+      ];
 
       for (const name of invalidNames) {
         await tester.expectBadRequest(`${baseUrl}?name=${name}`);

diff --git a/test/province.e2e-spec.ts b/test/province.e2e-spec.ts
@@ -1,6 +1,7 @@
 import { Province } from '@prisma/client';
 import { AppTester } from './helper/app-tester';
 import { provinceRegex } from './helper/data-regex';
+import { getEncodedSymbols } from './helper/utils';
 
 describe('Province (e2e)', () => {
   const baseUrl = '/provinces';
@@ -35,7 +36,7 @@ describe('Province (e2e)', () => {
 
   describe(`GET ${baseUrl}?name={name}`, () => {
     it('should return 400 if the `name` is more than 100 chars, or contains any symbols', async () => {
-      const invalidNames = ['x'.repeat(101), 'j@wa'];
+      const invalidNames = ['x'.repeat(101), ...getEncodedSymbols()];
 
       for (const name of invalidNames) {
         await tester.expectBadRequest(`${baseUrl}?name=${name}`);
@@ -51,7 +52,7 @@ describe('Province (e2e)', () => {
     });
 
     it('should return array of provinces that match with the `name`', async () => {
-      const testName = 'jawa';
+      const testName = 'jawa barat';
       const provinces = await tester.expectData<Province[]>(
         `${baseUrl}?name=${testName}`,
       );

diff --git a/test/regency.e2e-spec.ts b/test/regency.e2e-spec.ts
@@ -1,6 +1,7 @@
 import { Regency } from '@prisma/client';
 import { AppTester } from './helper/app-tester';
 import { regencyRegex } from './helper/data-regex';
+import { getEncodedSymbols } from './helper/utils';
 
 describe('Regency (e2e)', () => {
   const baseUrl = '/regencies';
@@ -27,7 +28,7 @@ describe('Regency (e2e)', () => {
     });
 
     it('should return 400 if the `name` is more than 100 chars, or contains any symbols', async () => {
-      const invalidNames = ['x'.repeat(101), 'b@ndung'];
+      const invalidNames = ['x'.repeat(101), ...getEncodedSymbols()];
 
       for (const name of invalidNames) {
         await tester.expectBadRequest(`${baseUrl}?name=${name}`);

diff --git a/test/village.e2e-spec.ts b/test/village.e2e-spec.ts
@@ -1,6 +1,7 @@
 import { Village } from '@prisma/client';
 import { AppTester } from './helper/app-tester';
 import { villageRegex } from './helper/data-regex';
+import { getEncodedSymbols } from './helper/utils';
 
 describe('Village (e2e)', () => {
   const baseUrl = '/villages';
@@ -27,7 +28,10 @@ describe('Village (e2e)', () => {
     });
 
     it("should return 400 if the `name` more than 100 chars, or contains any other symbols besides '()-./", async () => {
-      const invalidNames = ['x'.repeat(101), 'c!nunuk'];
+      const invalidNames = [
+        'x'.repeat(101),
+        ...getEncodedSymbols({ exclude: '()-./' }),
+      ];
 
       for (const name of invalidNames) {
         await tester.expectBadRequest(`${baseUrl}?name=${name}`);