Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make name query param optional #189

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Make name query param optional #189

merged 3 commits into from
Oct 3, 2023

Conversation

fityannugroho
Copy link
Owner

@fityannugroho fityannugroho commented Oct 3, 2023 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Contributing Guidelines
  • Tests for the changes have been added (optional, for bug fixes or features)
  • Docs have been added / updated (optional, for bug fixes or features)

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

What is the current behavior?

Issue Number: #188

What is the new behavior?

Now name query param of these endpoints below are optional:

  • /regencies
  • /districts
  • /islands
  • /villages

Other information

None

@fityannugroho fityannugroho linked an issue Oct 3, 2023 that may be closed by this pull request
Make name query optional #188
Closed
@fityannugroho fityannugroho merged commit 096a24f into main Oct 3, 2023
4 checks passed
@fityannugroho fityannugroho deleted the issue-188 branch October 3, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make name query optional
1 participant
@fityannugroho