Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed the island code #206

Merged
merged 1 commit into from
Oct 17, 2023
Merged

changed the island code #206

merged 1 commit into from
Oct 17, 2023

Conversation

rakeshrk6
Copy link

@rakeshrk6 rakeshrk6 commented Oct 16, 2023 •
edited by fityannugroho
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

Put "x" to check

  • The commit message follows our Contributing Guidelines
  • Tests for the changes have been added (optional, for bug fixes or features)
  • Docs have been added / updated (optional, for bug fixes or features)

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using "x"

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: #205

What is the new behavior?

Change the island code example into 110140001

Other information

Will resolve #205

@fityannugroho
Copy link
Owner

fityannugroho commented Oct 16, 2023 •
edited
Loading

@rakeshrk6 Please update the PR details first

Re:
I will update it for you this time. Henceforth, be sure to follow the Contributing Guidelines.

@fityannugroho fityannugroho self-requested a review October 17, 2023 22:12
fityannugroho
fityannugroho approved these changes Oct 17, 2023
View reviewed changes
Copy link
Owner

@fityannugroho fityannugroho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fityannugroho fityannugroho merged commit fa8bb2f into fityannugroho:main Oct 17, 2023
4 of 6 checks passed
@fityannugroho fityannugroho added the hacktoberfest-accepted Accepted PR during hacktoberfest label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fityannugroho fityannugroho fityannugroho approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted PR during hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the island code example
2 participants
@rakeshrk6 @fityannugroho