Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile and production start script #463

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Fix Dockerfile and production start script #463

merged 4 commits into from
Nov 20, 2024

Conversation

fityannugroho
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • The commit message follows our Contributing Guidelines
  • Tests for the changes have been added (optional, for bug fixes or features)
  • Docs have been added / updated (optional, for bug fixes or features)

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

  • Can't run pnpm run start:prod
  • Can't build the docker image

What is the new behavior?

This pull request includes changes to the Dockerfile and package.json to improve the build process and correct the production start script. The most important changes include consolidating commands in the Dockerfile and fixing the path for the production start script in package.json.

Improvements to Dockerfile:

  • Consolidated the installation of pnpm and creation of the working directory into a single command in both stages of the Dockerfile.
  • Combined multiple COPY commands into fewer commands to streamline the Dockerfile.
  • Combined the commands to run the Prisma generator and build the application into a single command.

Fixes in package.json:

  • Corrected the path for the production start script from dist/src/main to dist/main.

Other information

None

@fityannugroho fityannugroho added the bug Something isn't working label Nov 20, 2024
@fityannugroho fityannugroho merged commit 8e7d15f into main Nov 20, 2024
11 checks passed
@fityannugroho fityannugroho deleted the fix/prod branch November 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant