Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core module #4

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Add core module #4

merged 1 commit into from
Nov 18, 2023

Conversation

fityannugroho
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • I have read the documentation.
  • I have read and followed the Contributing Guidelines.
  • I have included a pull request description of my changes.
  • I have included the necessary changes to the documentation.
  • I have added tests to cover my changes.

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • ..... (describe the other type)

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

Currently, this package can be run only in Node.js environment. It doesn't works well for another environments including browsers and some edge runtimes which is doesn't support file system module (see fityannugroho/wisely-web#3).

What is the new behavior?

Create core module (wisely/core) that doesn't use built-in charsets, so it doesn't need file system module.

Other information

None

@fityannugroho fityannugroho added the enhancement New feature or request label Nov 18, 2023
@fityannugroho fityannugroho merged commit 6ef4a27 into main Nov 18, 2023
2 checks passed
@fityannugroho fityannugroho deleted the core-module branch November 18, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant