Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

FivetranSensor missing syncs that complete before the sensor starts #60

Closed
ANich opened this issue Jun 10, 2022 · 3 comments
Closed

FivetranSensor missing syncs that complete before the sensor starts #60

ANich opened this issue Jun 10, 2022 · 3 comments

Comments

@ANich
Copy link

ANich commented Jun 10, 2022

Hi, thanks for the work on this provider.

We've noticed an issue for syncs that complete quickly after being started by the FivetranOperator. The FivetranSensor starts and begins polling after the sync has completed, so it continuously receives a scheduled state until another sync is triggered or it's marked as SUCCESS externally. This leads to long-running sensors (daily syncs for e.g.).

You should be able to reproduce this with a connector that syncs quickly and a sleep operator between the fivetran_sync_start and the fivetran_sync_wait.

We've solved this by (1) removing the fivetran_sync_start >> fivetran_sync_wait dependency between the operator and the sensor so the sensor task doesn't block the operator task (2) setting sensor priority > operator priority so the sensor starts shortly before the operator.

(Seems like something like #49 may solve this. Perhaps identifying syncs could as well?)

@PubChimps
Copy link
Contributor

Thanks Alexander, we are solving this in the next release of the provider with XCOMs. I should have this release out and instructions on how to use the provider w/ XCOMs this week, I'll then post the instructions here and close this issue

@ANich
Copy link
Author

ANich commented Jun 15, 2022

Hi Nick, thanks for the response -- I'll keep an eye out for the next release then 👍

@PubChimps
Copy link
Contributor

Please update to version 1.1.0 and see this example for how to catch short syncs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants