Update Fivetran connector to v1.1.2 #1530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akkomar
requested changes
Jul 25, 2022
There was a problem hiding this comment.
Please rewrite the commit message so it is clear what and why is changing here.
Take a look at this post which contains some great examples and rationale: https://cbea.ms/git-commit/
That might be a question to @haroldwoo, but do we still need to backport this connector by copying the code here? Or maybe we can just install airflow-provider-fivetran==1.1.2?
alekhyamoz
force-pushed
the
fivetran_1.1.2
branch
from
a66e92a to
48e0927
Compare
alekhyamoz
changed the title
The link to the new hook.py can be found here https://github.com/fivetran/airflow-provider-fivetran/blob/main/fivetran_provider/hooks/fivetran.py. This is to catch the short syncs
alekhyamoz
force-pushed
the
fivetran_1.1.2
branch
from
48e0927 to
194959a
Compare
|
Can you create a DSRE Jira for installing the fivetran airflow provider 1.1.2 on the wtmo cluster? I can add this to a list of needs for when I upgrade airflow again. |
alekhyamoz
changed the title
|
@haroldwoo Created a Jira ticket :https://mozilla-hub.atlassian.net/browse/DSRE-921 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR would resolve the issue where the syncs are completed quickly after being started by the FivetranOperator.
More details here: fivetran/airflow-provider-fivetran#60
The Fivetran connector v1.1.2 will help us avoid the task priorities set in private_bqetl_revenue DAG: https://github.com/mozilla/private-bigquery-etl/blob/main/dags/private_bqetl_revenue.py#L152-L154
There would be a subsequent PR to make the necessary changes to the revenue DAG