Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.8.0 #53

Merged
merged 9 commits into from
Apr 2, 2024
Merged

Release/v0.8.0 #53

merged 9 commits into from
Apr 2, 2024

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Mar 21, 2024

PR Overview

This PR will address the following Issue/Feature:

This PR will result in the following new package version:

  • v0.8.0: breaking due to default schema change

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

Feature updates

  • Added default target schemas in dbt_project.yml.

Under the Hood:

  • Updated the maintainer PR template to the current format.
  • Incorporated the new fivetran_utils.drop_schemas_automation macro into the end of each Buildkite integration test job. (PR #49)
  • Updated the quickstart.yml file to allow for automated Quickstart data model deployments. (PR #51)

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

  • confirmed schema <target_schema>_github get's properly set

Screenshot 2024-03-22 at 2 44 20 PM

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-catfritz fivetran-catfritz self-assigned this Mar 21, 2024
@fivetran-catfritz fivetran-catfritz linked an issue Mar 21, 2024 that may be closed by this pull request
4 tasks
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and will approve, but have one comment below that I would like you to look into before merging.

dbt_project.yml Outdated
intermediate:
materialized: ephemeral
+materialized: ephemeral
+schema: int_github
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are all ephemeral then they won't actually be materialized in a schema. This is probably not necessary and can be removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these models are materialized then we are not documenting this in the README section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I kept this in case the user changed the materialization, however, if they're doing that they could also define their own schema and yeah this probably isn't necessary. Removed.

packages.yml Outdated
Comment on lines 2 to 6
# version: [">=0.8.0", "<0.9.0"]
- git: https://github.com/fivetran/dbt_github_source.git
revision: release/v0.8.0
warn-unpinned: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to swap before release

dbt_project.yml Outdated
intermediate:
materialized: ephemeral
+materialized: ephemeral
+schema: int_github
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I kept this in case the user changed the materialization, however, if they're doing that they could also define their own schema and yeah this probably isn't necessary. Removed.

dbt_project.yml Outdated Show resolved Hide resolved
@fivetran-catfritz fivetran-catfritz merged commit 488e78b into main Apr 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing target schemas config in dbt_package.yml
3 participants