-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v0.8.0 #53
Release/v0.8.0 #53
Conversation
Updating target schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and will approve, but have one comment below that I would like you to look into before merging.
dbt_project.yml
Outdated
intermediate: | ||
materialized: ephemeral | ||
+materialized: ephemeral | ||
+schema: int_github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are all ephemeral then they won't actually be materialized in a schema. This is probably not necessary and can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these models are materialized then we are not documenting this in the README section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. I kept this in case the user changed the materialization, however, if they're doing that they could also define their own schema and yeah this probably isn't necessary. Removed.
packages.yml
Outdated
# version: [">=0.8.0", "<0.9.0"] | ||
- git: https://github.com/fivetran/dbt_github_source.git | ||
revision: release/v0.8.0 | ||
warn-unpinned: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to swap before release
dbt_project.yml
Outdated
intermediate: | ||
materialized: ephemeral | ||
+materialized: ephemeral | ||
+schema: int_github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. I kept this in case the user changed the materialization, however, if they're doing that they could also define their own schema and yeah this probably isn't necessary. Removed.
PR Overview
This PR will address the following Issue/Feature:
This PR will result in the following new package version:
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
dbt run (if incremental models are present) && dbt testBefore marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
<target_schema>_github
get's properly setIf you had to summarize this PR in an emoji, which would it be?
💃