-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quickstart update #149
quickstart update #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change request before approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for release review with just one final request to change the PR reference in the CHANGELOG.
Co-authored-by: Joe Markiewicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-reneeli You're good to go!
PR Overview
This PR will address the following Issue/Feature:
This is a patch release accounting for the quickstart yml change so that quickstart will succesfully deploy.
This PR will result in the following new package version:
v0.19.1
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
hubspot__daily_ticket_history
,hubspot__tickets
from the quickstart.yml since these models may not always be present.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
na
If you had to summarize this PR in an emoji, which would it be?
💃