Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickstart update #149

Merged
merged 5 commits into from
Oct 24, 2024
Merged

quickstart update #149

merged 5 commits into from
Oct 24, 2024

Conversation

fivetran-reneeli
Copy link
Contributor

PR Overview

This PR will address the following Issue/Feature:
This is a patch release accounting for the quickstart yml change so that quickstart will succesfully deploy.

This PR will result in the following new package version:

v0.19.1

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

  • Removed hubspot__daily_ticket_history, hubspot__tickets from the quickstart.yml since these models may not always be present.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • [na] The appropriate issue has been linked, tagged, and properly assigned
  • [na] All necessary documentation and version upgrades have been applied
  • [na] docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

na

If you had to summarize this PR in an emoji, which would it be?

💃

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change request before approval.

CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for release review with just one final request to change the PR reference in the CHANGELOG.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli You're good to go!

@fivetran-reneeli fivetran-reneeli merged commit 86bac99 into main Oct 24, 2024
9 checks passed
@fivetran-reneeli fivetran-reneeli deleted the release/v0.19.1 branch October 24, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants