-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce category field upstream #150
Changes from 14 commits
69ea5e4
8ee9fe1
8c98a25
fb3c82f
5d84090
e349f40
d59dec1
959d264
27b2961
3caa4d5
ea641c5
2b6950e
02f3698
f6f9e7d
948dbfe
753f5b3
f180d8b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,21 @@ | ||
# dbt_hubspot v0.20.0 | ||
[PR #150](https://github.com/fivetran/dbt_hubspot/pull/150) includes the following updates: | ||
|
||
## Breaking Change (`--full-refresh` required after upgrading) | ||
- Introduced a new `category` column to the below models. This association field differentiates records by either HUBSPOT_DEFINED (default label) or USER_DEFINED (custom label) and was introduced to the Hubspot connector in October 2024. See the [connector release notes](https://fivetran.com/docs/connectors/applications/hubspot/changelog#october2024) for more. | ||
- `stg_hubspot__deal_company` | ||
- `stg_hubspot__deal_contact` | ||
- `stg_hubspot__engagement_company` | ||
- `stg_hubspot__engagement_contact` | ||
- `stg_hubspot__engagement_deal` | ||
- `stg_hubspot__ticket_company` | ||
- `stg_hubspot__ticket_contact` | ||
- `stg_hubspot__ticket_deal` | ||
- `stg_hubspot__ticket_engagement` | ||
|
||
## Under the Hood | ||
- Updated the respective seed files in the integration_tests folder to property test for the new `category` field. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like you also updated seed files as well to match the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks updated! |
||
|
||
# dbt_hubspot v0.19.1 | ||
[PR #148](https://github.com/fivetran/dbt_hubspot/pull/148) includes the following updates: | ||
|
||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,29 @@ | ||
name: 'hubspot_integration_tests' | ||
version: '0.19.1' | ||
version: '0.20.0' | ||
|
||
profile: 'integration_tests' | ||
config-version: 2 | ||
|
||
models: | ||
+schema: "{{ 'hubspot_sqlw_tests_3' if target.name == 'databricks-sql' else 'hubspot' }}" | ||
+schema: "{{ 'hubspot_sqlw_tests_5' if target.name == 'databricks-sql' else 'hubspot' }}" | ||
# +schema: "hubspot_{{ var('directed_schema','dev') }}" ## To be used for validation testing | ||
|
||
vars: | ||
hubspot_schema: hubspot_integration_tests_59 | ||
hubspot_schema: hubspot_integration_tests_62 | ||
# hubspot__pass_through_all_columns: true | ||
# hubspot__company_pass_through_columns: | ||
# - name: "property_hs_all-funky-a9384-syntax" | ||
# alias: "funky_field" | ||
# hubspot_service_enabled: true # enable when generating docs | ||
# hubspot_deal_enabled: true # enable when generating docs | ||
# hubspot_contact_enabled: true # enable when generating docs | ||
# hubspot_sales_enabled: true # enable when generating docs | ||
# hubspot_company_enabled: true # enable when generating docs | ||
# hubspot_service_enabled: true # enable when generating docs | ||
# hubspot_marketing_enabled: true # enable when generating docs | ||
# hubspot_contact_merge_audit_enabled: true # enable when generating docs | ||
# hubspot_using_all_email_events: true # enable when generating docs | ||
# hubspot_merged_deal_enabled: true # enable when generating docs | ||
# hubspot_merged_deal_enabled: true # enable when generating docs | ||
# hubspot_ticket_deal_enabled: true # enable when generating docs | ||
hubspot_company_property_history_identifier: "company_property_history_data" | ||
hubspot_company_identifier: "company_data" | ||
hubspot_contact_identifier: "contact_data" | ||
|
@@ -87,28 +90,33 @@ seeds: | |
+alias: company_data | ||
+enabled: "{{ true if target.type == 'postgres' else false }}" | ||
+column_types: | ||
id: bigint | ||
id: "{{ 'int64' if target.type == 'bigquery' else 'bigint' }}" | ||
company_data_snowflake: | ||
+alias: company_data | ||
+enabled: "{{ true if target.type == 'snowflake' else false }}" | ||
+column_types: | ||
id: bigint | ||
id: "{{ 'int64' if target.type == 'bigquery' else 'bigint' }}" | ||
company_data_databricks: | ||
+alias: company_data | ||
+enabled: "{{ true if target.type == 'databricks' else false }}" | ||
+enabled: "{{ true if target.type in ('databricks','databricks-sql') else false }}" | ||
+column_types: | ||
id: bigint | ||
deal_stage_data: | ||
id: "{{ 'int64' if target.type == 'bigquery' else 'bigint' }}" | ||
deal_data: | ||
+column_types: | ||
deal_id: "{{ 'int64' if target.type == 'bigquery' else 'bigint' }}" | ||
owner_id: "{{ 'int64' if target.type == 'bigquery' else 'bigint' }}" | ||
_fivetran_synced: timestamp | ||
property_closedate: timestamp | ||
property_createdate: timestamp | ||
deal_pipeline_id: "{{ 'varchar(100)' if target.type in ('redshift','postgres') else 'string'}}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like lines 111-112 were not added in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh right that was added in the transforms because buildkite was failing in this package. but yes added it to hubspot_source |
||
deal_pipeline_stage_id: "{{ 'varchar(100)' if target.type in ('redshift','postgres') else 'string'}}" | ||
deal_contact_data: | ||
+column_types: | ||
contact_id: "{{ 'int64' if target.type == 'bigquery' else 'bigint' }}" | ||
deal_id: "{{ 'int64' if target.type == 'bigquery' else 'bigint' }}" | ||
deal_data: | ||
deal_stage_data: | ||
+column_types: | ||
deal_id: "{{ 'int64' if target.type == 'bigquery' else 'bigint' }}" | ||
owner_id: "{{ 'int64' if target.type == 'bigquery' else 'bigint' }}" | ||
company_property_history_data: | ||
+column_types: | ||
company_id: "{{ 'int64' if target.type == 'bigquery' else 'bigint' }}" | ||
|
@@ -137,6 +145,7 @@ seeds: | |
+column_types: | ||
engagement_id: "{{ 'int64' if target.type == 'bigquery' else 'bigint' }}" | ||
deal_id: "{{ 'int64' if target.type == 'bigquery' else 'bigint' }}" | ||
created_at: timestamp | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should probably add this in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added |
||
engagement_data: | ||
+column_types: | ||
id: "{{ 'int64' if target.type == 'bigquery' else 'bigint' }}" | ||
|
@@ -172,6 +181,7 @@ seeds: | |
deal_pipeline_stage_data: | ||
+column_types: | ||
stage_id: "{{ 'varchar(100)' if target.type in ('redshift','postgres') else 'string'}}" | ||
pipeline_id: "{{ 'varchar(100)' if target.type in ('redshift','postgres') else 'string'}}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like this line was not added in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks for noticing these! |
||
email_event_sent_data_snowflake: | ||
+alias: email_event_sent_data | ||
+enabled: "{{ true if target.type == 'snowflake' else false }}" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,23 @@ | ||
_fivetran_deleted,_fivetran_synced,property_email,id,property_company,property_firstname,property_lastname,property_email_1,property_createdate,property_jobtitle,property_annualrevenue,property_hs_calculated_merged_vids,property_created_at | ||
FALSE,2021-04-02 11:16:05,fcb67ef339b691956cc85fa12be6490c,78971951,SampleCompany,db320f93ead463e1a2faee198cd9a122,22370ea245fce0b355938327d41bd1e4,261d3936e165a33b3f31e5fdd0e3121d,2021-04-01 17:32:47,,111111,76340251:1661707291575;46897301:1661707931852;76226001:1661696530403,2021-04-01 17:32:47 | ||
FALSE,2021-03-22 11:16:06,6528bb7211b1dc066fc5c292561150c2,76340251,,b70e7b267b0652ee4030c4043cba7cf7,a0a1e71392fc13041b04f743c6727ca2,629f41f1733632c69114a624bca1e1d5,2021-03-21 14:33:30,,111111,,2021-03-21 14:33:30 | ||
FALSE,2021-04-02 11:20:23,3abfda161ad50142007f6107db915761,46897301,,c13e13da2073260c2194c15d782e86a9,26c4e5c8064dc58f08b4ef2ebf463beb,4e52945af09feaa93bcfbf710fb23570,2020-10-08 21:13:55,,111111,,2020-10-08 21:13:55 | ||
FALSE,2021-03-22 11:16:08,d8215e6e62b9398166ad67ca484fc58d,76226001,,48bc893fcbc0a33ed3ad2cf2d5d57cfe,7a03155bc7e8c00f13d70edae7974096,0474ac00326d6e93558e7727da5e3bdc,2021-03-20 21:42:56,,111111,,2021-03-20 21:42:56 | ||
FALSE,2021-04-02 11:19:58,d63232cbab97fc1bb5808e4cba500347,36842001,,a703d6d14769d658f85a3b4c2c1ef9c7,5f55afd748fc4ad2580b768611325148,af58c55d6520c2470fd58e6893c06816,2020-07-15 04:46:01,,111111,,2020-07-15 04:46:01 | ||
FALSE,2021-04-02 11:17:59,67717a9896fdbf93e2fa6655e75eb70f,55703851,,bf7c755353603f0bfca9f2070dbaa923,526664ec12dc5105f2c3171ca0909570,8370f130e1bb6435da412b168e29a0ab,2020-12-03 14:43:55,,111111,,2020-12-03 14:43:55 | ||
FALSE,2021-04-02 11:17:15,90d65041363376d2abd1f0916df8fa42,74075201,,464e07afc9e46359fb480839150595c5,9c6e765da2eebc87f290f43f74d57c8d,24e5c02e37b9441c33978a53038200d4,2021-03-11 13:08:45,,111111,,2021-03-11 13:08:45 | ||
FALSE,2021-04-02 11:21:27,226045995fbc87c01b2eb3847bc4ea8f,48722101,,464e07afc9e46359fb480839150595c5,7fe70fef470fcc46826966e201147015,5cf8d1f804144c2ef34dc98db0fd0105,2020-10-24 13:28:24,,111111,,2020-10-24 13:28:24 | ||
FALSE,2021-04-02 11:22:22,b26ae870d0b4763efe3f4bbc53aab1d6,48067201,,8295bd3d7037a0e0c2ee11c99050a9c1,59830e37ce261d31ad0da0d5d270d0e1,abd71c63abd25c0f8286e76f319b9939,2020-10-19 02:34:46,,111111,,2020-10-19 02:34:46 | ||
FALSE,2021-04-02 11:20:39,52a2d91b793f582dbe837ea464505732,69869451,,81b8a1b77068d06e1c8190825253066f,20c0c9b9bd7addf3a005da2e3ff184f4,674c0664494482302ec62fa4f11947bc,2021-02-19 13:23:50,,111111,,2021-02-19 13:23:50 | ||
FALSE,2021-04-02 11:20:49,cba06e5c14a5aecfbb42d2e813ceb18e,32820151,,399423ff652ebb6a6701be7ec3202fc6,c22e1816539af64a7eadc2b81c3a1905,a37a075d75315d60478339a67c39340f,2020-05-22 16:46:41,,111111,,2020-05-22 16:46:41 | ||
FALSE,2021-04-02 11:21:02,045ddfbc7f5c8b229872583f77677b88,70526501,,399423ff652ebb6a6701be7ec3202fc6,c1861b5a8a30be3af3f7fd5e1592296a,4dd5fdb40b67ee13fc486d0073df7bcb,2021-02-22 12:18:44,,111111,,2021-02-22 12:18:44 | ||
FALSE,2021-04-02 11:16:53,033e21ce25808e0cda0d02b859ee0690,69487901,,7802feb8467a9bc4dba34269b099230f,36bc4059766459cd3364e405157aa855,263a8a2a4bf46bd88b3fb46072b56982,2021-02-18 15:40:04,,111111,,2021-02-18 15:40:04 | ||
FALSE,2021-04-02 11:16:28,693f827dd3adc99c5eb1403f5758dc69,41932551,,4d236810821e8e83a025f2a83ea31820,b18e66b41efd9a3df1a7bc8758da1883,a1ea6eae3d51c7c339478f8ddc3190cf,2020-08-31 04:44:28,,111111,,2020-08-31 04:44:28 | ||
FALSE,2021-04-02 11:22:04,0de6489271133caa4da8e73898a66616,75141301,,7c1f90bd9bdc70cc059640a7a6209389,e1229bab1c271d1f1796cb0c52ab9933,c6bf5326b632c7411bd68500eb283e0c,2021-03-16 01:44:16,,111111,,2021-03-16 01:44:16 | ||
FALSE,2021-04-02 11:16:59,8c1596c5770ae37d6db57236eabf2883,42820351,,e1229bab1c271d1f1796cb0c52ab9933,b7a71d8799cf6dd75b711a7f52de6675,3d5c92d654be9b684cc91ec6143323d5,2020-09-07 16:19:50,,111111,,2020-09-07 16:19:50 | ||
FALSE,2021-04-02 11:15:59,458e4126009a63e8f549af197a6b72f7,79092001,,4ffe35db90d94c6041fb8ddf7b44df29,da4660701a8f38bf4956342c95d87d21,991c1b99ab97f625eb1ead100949bfc9,2021-04-02 01:12:17,,111111,,2021-04-02 01:12:17 | ||
FALSE,2021-04-02 11:22:07,3f9e56a211a07baa5836171617f978a8,56072901,,c477d14fc1b786cb85f4b23a0b00fe1c,d8a1d6833510c7544156f41c55aec258,8c9975dd59d43d516775fde0eb57c03f,2020-12-05 17:49:01,,111111,,2020-12-05 17:49:01 | ||
FALSE,2021-04-02 11:17:41,6f1eb8fdc225b3b026898b68df5d5be2,39543551,,7f15f1ad99c489dc0314952535e424d5,6252d6e4aef4917a48e2660a821732e3,74be16979710d4c4e7c6647856088456,2020-08-13 15:34:30,,111111,,2020-08-13 15:34:30 | ||
FALSE,2021-04-02 11:16:22,0a28bb660df1a8d53b40999f1b1fe2b5,33419651,,d52e32f3a96a64786814ae9b5279fbe5,630a16c4dbe8f48822a279b4a554916f,a71704548944161196a1841e61a3cb4c,2020-06-01 21:13:09,,111111,,2020-06-01 21:13:09 | ||
FALSE,2021-04-02 11:21:02,1bd784044acca0b18e917d0255cc619d,69477701,,61409aa1fd47d4a5332de23cbf59a36f,10af01955bb93519c3c287d7e60c670b,e70d013e17f9dd4a17bc37c0a5c0f203,2021-02-18 15:21:47,,111111,,2021-02-18 15:21:47 | ||
_fivetran_deleted,_fivetran_synced,property_email,id,property_company,property_firstname,property_lastname,property_email_1,property_createdate,property_jobtitle,property_annualrevenue,property_hs_calculated_merged_vids,property_created_at | ||
FALSE,2021-04-02 11:16:05,fcb67ef339b691956cc85fa12be6490c,78971951,SampleCompany,db320f93ead463e1a2faee198cd9a122,22370ea245fce0b355938327d41bd1e4,261d3936e165a33b3f31e5fdd0e3121d,2021-04-01 17:32:47,,111111,76340251:1661707291575;46897301:1661707931852;76226001:1661696530403,2021-04-01 17:32:47 | ||
FALSE,2021-03-22 11:16:06,6528bb7211b1dc066fc5c292561150c2,76340251,,b70e7b267b0652ee4030c4043cba7cf7,a0a1e71392fc13041b04f743c6727ca2,629f41f1733632c69114a624bca1e1d5,2021-03-21 14:33:30,,111111,,2021-03-21 14:33:30 | ||
FALSE,2021-04-02 11:20:23,3abfda161ad50142007f6107db915761,46897301,,c13e13da2073260c2194c15d782e86a9,26c4e5c8064dc58f08b4ef2ebf463beb,4e52945af09feaa93bcfbf710fb23570,2020-10-08 21:13:55,,111111,,2020-10-08 21:13:55 | ||
FALSE,2021-03-22 11:16:08,d8215e6e62b9398166ad67ca484fc58d,76226001,,48bc893fcbc0a33ed3ad2cf2d5d57cfe,7a03155bc7e8c00f13d70edae7974096,0474ac00326d6e93558e7727da5e3bdc,2021-03-20 21:42:56,,111111,,2021-03-20 21:42:56 | ||
FALSE,2021-04-02 11:19:58,d63232cbab97fc1bb5808e4cba500347,36842001,,a703d6d14769d658f85a3b4c2c1ef9c7,5f55afd748fc4ad2580b768611325148,af58c55d6520c2470fd58e6893c06816,2020-07-15 04:46:01,,111111,,2020-07-15 04:46:01 | ||
FALSE,2021-04-02 11:17:59,67717a9896fdbf93e2fa6655e75eb70f,55703851,,bf7c755353603f0bfca9f2070dbaa923,526664ec12dc5105f2c3171ca0909570,8370f130e1bb6435da412b168e29a0ab,2020-12-03 14:43:55,,111111,,2020-12-03 14:43:55 | ||
FALSE,2021-04-02 11:17:15,90d65041363376d2abd1f0916df8fa42,74075201,,464e07afc9e46359fb480839150595c5,9c6e765da2eebc87f290f43f74d57c8d,24e5c02e37b9441c33978a53038200d4,2021-03-11 13:08:45,,111111,,2021-03-11 13:08:45 | ||
FALSE,2021-04-02 11:21:27,226045995fbc87c01b2eb3847bc4ea8f,48722101,,464e07afc9e46359fb480839150595c5,7fe70fef470fcc46826966e201147015,5cf8d1f804144c2ef34dc98db0fd0105,2020-10-24 13:28:24,,111111,,2020-10-24 13:28:24 | ||
FALSE,2021-04-02 11:22:22,b26ae870d0b4763efe3f4bbc53aab1d6,48067201,,8295bd3d7037a0e0c2ee11c99050a9c1,59830e37ce261d31ad0da0d5d270d0e1,abd71c63abd25c0f8286e76f319b9939,2020-10-19 02:34:46,,111111,,2020-10-19 02:34:46 | ||
FALSE,2021-04-02 11:20:39,52a2d91b793f582dbe837ea464505732,69869451,,81b8a1b77068d06e1c8190825253066f,20c0c9b9bd7addf3a005da2e3ff184f4,674c0664494482302ec62fa4f11947bc,2021-02-19 13:23:50,,111111,,2021-02-19 13:23:50 | ||
FALSE,2021-04-02 11:20:49,cba06e5c14a5aecfbb42d2e813ceb18e,32820151,,399423ff652ebb6a6701be7ec3202fc6,c22e1816539af64a7eadc2b81c3a1905,a37a075d75315d60478339a67c39340f,2020-05-22 16:46:41,,111111,,2020-05-22 16:46:41 | ||
FALSE,2021-04-02 11:21:02,045ddfbc7f5c8b229872583f77677b88,70526501,,399423ff652ebb6a6701be7ec3202fc6,c1861b5a8a30be3af3f7fd5e1592296a,4dd5fdb40b67ee13fc486d0073df7bcb,2021-02-22 12:18:44,,111111,,2021-02-22 12:18:44 | ||
FALSE,2021-04-02 11:16:53,033e21ce25808e0cda0d02b859ee0690,69487901,,7802feb8467a9bc4dba34269b099230f,36bc4059766459cd3364e405157aa855,263a8a2a4bf46bd88b3fb46072b56982,2021-02-18 15:40:04,,111111,,2021-02-18 15:40:04 | ||
FALSE,2021-04-02 11:16:28,693f827dd3adc99c5eb1403f5758dc69,41932551,,4d236810821e8e83a025f2a83ea31820,b18e66b41efd9a3df1a7bc8758da1883,a1ea6eae3d51c7c339478f8ddc3190cf,2020-08-31 04:44:28,,111111,,2020-08-31 04:44:28 | ||
FALSE,2021-04-02 11:22:04,0de6489271133caa4da8e73898a66616,75141301,,7c1f90bd9bdc70cc059640a7a6209389,e1229bab1c271d1f1796cb0c52ab9933,c6bf5326b632c7411bd68500eb283e0c,2021-03-16 01:44:16,,111111,,2021-03-16 01:44:16 | ||
FALSE,2021-04-02 11:16:59,8c1596c5770ae37d6db57236eabf2883,42820351,,e1229bab1c271d1f1796cb0c52ab9933,b7a71d8799cf6dd75b711a7f52de6675,3d5c92d654be9b684cc91ec6143323d5,2020-09-07 16:19:50,,111111,,2020-09-07 16:19:50 | ||
FALSE,2021-04-02 11:15:59,458e4126009a63e8f549af197a6b72f7,79092001,,4ffe35db90d94c6041fb8ddf7b44df29,da4660701a8f38bf4956342c95d87d21,991c1b99ab97f625eb1ead100949bfc9,2021-04-02 01:12:17,,111111,,2021-04-02 01:12:17 | ||
FALSE,2021-04-02 11:22:07,3f9e56a211a07baa5836171617f978a8,56072901,,c477d14fc1b786cb85f4b23a0b00fe1c,d8a1d6833510c7544156f41c55aec258,8c9975dd59d43d516775fde0eb57c03f,2020-12-05 17:49:01,,111111,,2020-12-05 17:49:01 | ||
FALSE,2021-04-02 11:17:41,6f1eb8fdc225b3b026898b68df5d5be2,39543551,,7f15f1ad99c489dc0314952535e424d5,6252d6e4aef4917a48e2660a821732e3,74be16979710d4c4e7c6647856088456,2020-08-13 15:34:30,,111111,,2020-08-13 15:34:30 | ||
FALSE,2021-04-02 11:16:22,0a28bb660df1a8d53b40999f1b1fe2b5,33419651,,d52e32f3a96a64786814ae9b5279fbe5,630a16c4dbe8f48822a279b4a554916f,a71704548944161196a1841e61a3cb4c,2020-06-01 21:13:09,,111111,,2020-06-01 21:13:09 | ||
FALSE,2021-04-02 11:21:02,1bd784044acca0b18e917d0255cc619d,69477701,,61409aa1fd47d4a5332de23cbf59a36f,10af01955bb93519c3c287d7e60c670b,e70d013e17f9dd4a17bc37c0a5c0f203,2021-02-18 15:21:47,,111111,,2021-02-18 15:21:47 | ||
FALSE,2021-04-02 11:22:27,d547e990ecd4e5e327b41f98cb8f3f4d,39893151,,6fa95b1427af77b3d769ae9cb853382f,f55fbaaca148300ac11f7752528cae3d,bc16a8351419c08a72f2169f4d2ade21,2020-08-17 02:50:12,,111111,,2020-08-17 02:50:12 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
canonical_vid,contact_id,vid_to_merge,_fivetran_synced,entity_id,first_name,last_name,num_properties_moved,timestamp,user_id | ||
5555,5555,2147483648,2020-12-30 11:20:31,json,,,2,2019-10-08 15:50:57, | ||
5555,5555,11111,2020-12-30 11:20:31,json,,,2,2019-10-08 15:50:57, | ||
4444,4444,7777,2021-01-09 11:16:00,json,,,2,2019-09-03 15:39:29, | ||
3333,3333,8888,2020-12-29 11:16:02,json,,,2,2019-11-20 20:17:59, | ||
2222,2222,9999,2020-12-30 11:16:58,json,,,2,2019-12-10 18:14:34, |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
company_id,deal_id,type_id | ||
12345,6789,101112 | ||
56789,1234,101112 | ||
company_id,deal_id,type_id,category | ||
12345,6789,101112,HUBSPOT_DEFINED | ||
56789,1234,101112,HUBSPOT_DEFINED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These breaking changes are occurring in
dbt_hubspot_source
. We should call that out here as Upstream Breaking Changes and link to thedbt_hubspot_source
release notes or changelog. You could use this PR you previously wrote for an upstream change as an example for how to reword it (i.e."because new columns are being added to this staging models, a --full-refresh is needed to access them"), and also link to the
dbt_hubspot_source
CHANGELOG section or release notes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's weird, this got separated out in the PR notes. Apologies.
Highly recommend making these updates, as it isn't quite clear from this CHANGELOG that these changes are being made in the source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah thanks Avinash sorry to not catch this! just updated, lmk what you think