Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Zendesk hyperlink additions #9

Merged
merged 7 commits into from
Nov 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# dbt_unified_rag v0.1.0-a3
fivetran-joemarkiewicz marked this conversation as resolved.
Show resolved Hide resolved
[PR #9](https://github.com/fivetran/dbt_unified_rag/pull/9) includes the following updates:

## Bug Fix (`--full-refresh` required when upgrading)
- Updated the `url` logic in `stg_rag_zendesk__ticket` to provide the proper clickable URL to Zendesk tickets. This way, the `url_reference` in the `rag__unified_document` properly generates a hyperlink for Zendesk documents.
- As this is updating underlying data flowing into the incremental model, a full refresh is required.

# dbt_unified_rag v0.1.0-a2

[PR #7](https://github.com/fivetran/dbt_unified_rag/pull/7) includes the following updates:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Include the following package_display_name package version in your `packages.yml
```yml
packages:
- package: fivetran/unified_rag
version: 0.1.0-a2
version: 0.1.0-a3
```

### Step 3: Define database and schema variables
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

253 changes: 214 additions & 39 deletions docs/index.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

20 changes: 10 additions & 10 deletions integration_tests/seeds/zendesk_ticket.csv
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
id,_fivetran_synced,allow_channelback,assignee_id,brand_id,created_at,description,due_at,external_id,forum_topic_id,group_id,has_incidents,is_public,organization_id,priority,problem_id,recipient,requester_id,status,subject,submitter_id,system_client,ticket_form_id,type,updated_at,url,via_channel,via_source_from_id,via_source_from_title,via_source_rel,via_source_to_address,via_source_to_name,merged_ticket_ids,via_source_from_address,followup_ids,via_followup_source_id
1595,2020-03-20 02:32:49.426,FALSE,,403958466973,2020-02-19 01:54:52,description1,,,,360006965034,FALSE,TRUE,370295712714,,,[email protected],396331237134,deleted,subject1,396331237134,,360002048693,incident,2020-02-19 01:55:11,https://zendesk.com/api/v2/tickets/1595.json,web,,,,[email protected],,[],,,
16988,2021-01-13 20:09:16.325,FALSE,403958466973,360003529474,2020-12-22 00:19:23,description1,,,,360013366274,FALSE,TRUE,370469077513,,,[email protected],1500656884401,solved,subject1,1500656884401,,360002048693,,2021-01-13 18:42:39,https://zendesk.com/api/v2/tickets/16988.json,email,,,,[email protected],Support,[],,[],
14173,2020-11-11 20:08:45.130,FALSE,403958466973,360003529474,2020-10-28 12:03:02,description1,,,,360006965034,FALSE,TRUE,370321120273,,,[email protected],424883466453,closed,subject1,424883466453,,360002048693,,2020-11-11 17:01:32,https://zendesk.com/api/v2/tickets/14173.json,email,,,,[email protected],Support,[],,,
11071,2020-10-02 14:08:33.216,FALSE,,403958466973,2020-08-28 18:06:36,description1,,,,,FALSE,TRUE,,,,[email protected],419755385214,deleted,subject1,419755385214,,360002048693,,2020-09-02 11:01:27,https://zendesk.com/api/v2/tickets/11071.json,email,,,,X,Support,[],,,
1966,2020-03-25 20:32:23.617,FALSE,403970285734,360003529474,2020-02-27 06:05:08,description1,,,,360006965034,FALSE,TRUE,370295721514,,,[email protected],402813302773,closed,subject1,402813302773,,360002048693,,2020-03-25 16:03:26,https://zendesk.com/api/v2/tickets/1966.json,email,,,,[email protected],Support,[1967],,,
11013,2020-10-02 20:08:20.449,FALSE,403970285734,360003529474,2020-08-27 23:09:52,description1,,,,360008376313,FALSE,TRUE,370297881854,,,[email protected],419688934974,deleted,subject1,419688934974,,360002048693,,2020-09-02 15:53:16,https://zendesk.com/api/v2/tickets/11013.json,email,,,,X,Support,[],,,
1404,2020-03-05 04:53:46.466,FALSE,403970285734,360003529474,2020-02-13 21:43:58,description1,,,,360006965034,FALSE,TRUE,370295709874,,,[email protected],403125197514,closed,subject1,403125197514,,360002048693,,2020-02-28 01:01:57,https://zendesk.com/api/v2/tickets/1404.json,email,,,,[email protected],Support,,,,
4721,2020-05-14 20:12:36.297,FALSE,403970285734,360003529474,2020-04-20 14:31:46,description1,,,,360006965034,FALSE,TRUE,370295719414,,,[email protected],402862357193,closed,subject1,402862357193,,360002048693,,2020-05-14 20:04:34,https://zendesk.com/api/v2/tickets/4721.json,email,,,,[email protected],Support,[],,,
6171,2020-06-01 02:11:39.760,FALSE,403969141094,360003529474,2020-05-17 17:50:31,description1,,,,360006965034,FALSE,TRUE,370295713034,,,[email protected],410930434074,closed,subject1,410930434074,,360002048693,,2020-05-31 23:03:46,https://zendesk.com/api/v2/tickets/6171.json,email,,,,[email protected],Support,[],,,
6605,2020-06-10 02:10:24.202,FALSE,403969141094,360003529474,2020-05-26 22:29:50,description1,,,,360006965034,FALSE,TRUE,370295719754,,,[email protected],410416672973,closed,subject1,410416672973,,360002048693,,2020-06-09 23:03:49,https://zendesk.com/api/v2/tickets/6605.json,email,,,,[email protected],Support,[],,,
1595,2020-03-20 02:32:49.426,FALSE,,403958466973,2020-02-19 01:54:52,description1,,,,360006965034,FALSE,TRUE,370295712714,,,[email protected],396331237134,deleted,subject1,396331237134,,360002048693,incident,2020-02-19 01:55:11,https://dev.zendesk.com/agent/tickets/1595,web,,,,[email protected],,[],,,
16988,2021-01-13 20:09:16.325,FALSE,403958466973,360003529474,2020-12-22 00:19:23,description1,,,,360013366274,FALSE,TRUE,370469077513,,,[email protected],1500656884401,solved,subject1,1500656884401,,360002048693,,2021-01-13 18:42:39,https://dev.zendesk.com/agent/tickets/16988,email,,,,[email protected],Support,[],,[],
14173,2020-11-11 20:08:45.130,FALSE,403958466973,360003529474,2020-10-28 12:03:02,description1,,,,360006965034,FALSE,TRUE,370321120273,,,[email protected],424883466453,closed,subject1,424883466453,,360002048693,,2020-11-11 17:01:32,https://dev.zendesk.com/agent/tickets/14173,email,,,,[email protected],Support,[],,,
11071,2020-10-02 14:08:33.216,FALSE,,403958466973,2020-08-28 18:06:36,description1,,,,,FALSE,TRUE,,,,[email protected],419755385214,deleted,subject1,419755385214,,360002048693,,2020-09-02 11:01:27,https://dev.zendesk.com/agent/tickets/11071,email,,,,X,Support,[],,,
1966,2020-03-25 20:32:23.617,FALSE,403970285734,360003529474,2020-02-27 06:05:08,description1,,,,360006965034,FALSE,TRUE,370295721514,,,[email protected],402813302773,closed,subject1,402813302773,,360002048693,,2020-03-25 16:03:26,https://dev.zendesk.com/agent/tickets/1966,email,,,,[email protected],Support,[1967],,,
11013,2020-10-02 20:08:20.449,FALSE,403970285734,360003529474,2020-08-27 23:09:52,description1,,,,360008376313,FALSE,TRUE,370297881854,,,[email protected],419688934974,deleted,subject1,419688934974,,360002048693,,2020-09-02 15:53:16,https://dev.zendesk.com/agent/tickets/11013,email,,,,X,Support,[],,,
1404,2020-03-05 04:53:46.466,FALSE,403970285734,360003529474,2020-02-13 21:43:58,description1,,,,360006965034,FALSE,TRUE,370295709874,,,[email protected],403125197514,closed,subject1,403125197514,,360002048693,,2020-02-28 01:01:57,https://dev.zendesk.com/agent/tickets/1404,email,,,,[email protected],Support,,,,
4721,2020-05-14 20:12:36.297,FALSE,403970285734,360003529474,2020-04-20 14:31:46,description1,,,,360006965034,FALSE,TRUE,370295719414,,,[email protected],402862357193,closed,subject1,402862357193,,360002048693,,2020-05-14 20:04:34,https://dev.zendesk.com/agent/tickets/4721,email,,,,[email protected],Support,[],,,
6171,2020-06-01 02:11:39.760,FALSE,403969141094,360003529474,2020-05-17 17:50:31,description1,,,,360006965034,FALSE,TRUE,370295713034,,,[email protected],410930434074,closed,subject1,410930434074,,360002048693,,2020-05-31 23:03:46,https://dev.zendesk.com/agent/tickets/6171,email,,,,[email protected],Support,[],,,
6605,2020-06-10 02:10:24.202,FALSE,403969141094,360003529474,2020-05-26 22:29:50,description1,,,,360006965034,FALSE,TRUE,370295719754,,,[email protected],410416672973,closed,subject1,410416672973,,360002048693,,2020-06-09 23:03:49,https://dev.zendesk.com/agent/tickets/6605,email,,,,[email protected],Support,[],,,
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ with tickets as (
), ticket_details as (
select
tickets.ticket_id,
tickets.url as url_reference,
replace(replace(cast(tickets.url as {{ dbt.type_string() }}), '/api/v2/tickets/', '/agent/tickets/'), '.json', '') as url_reference,
fivetran-joemarkiewicz marked this conversation as resolved.
Show resolved Hide resolved
tickets.source_relation,
tickets.subject as ticket_name,
{{ unified_rag.coalesce_cast(["users.name", "'UNKNOWN'"], dbt.type_string()) }} as user_name,
Expand Down