Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Sidekick quickstart edits. #281

Closed
wants to merge 2 commits into from

Conversation

mdwelsh
Copy link
Contributor

@mdwelsh mdwelsh commented Sep 13, 2023

Made some proposed edits to the Sidekick quickstart. Definitely a few things we need to chase down in the next couple of days, but all doable.

I recommend we just push these changes to the live docs site and work off of main since I don't think it gets so much traffic that people are gonna get confused if we start rolling things out.

@mdwelsh mdwelsh requested a review from benlower September 13, 2023 05:10
@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai-jsx-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 4:31pm
ai-jsx-nextjs-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 4:31pm
ai-jsx-tutorial-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 4:31pm


### Method 1: Via curl
> TODO(matt): Figure out the right invocation for this.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NickHeiner
Copy link
Contributor

NickHeiner commented Sep 13, 2023

I recommend we just push these changes to the live docs site and work off of main

I feel pretty strongly that if we do this, we should remove the todos first. But I won't gatekeep on it.

That said, branch in general is a big improvement over what we have live, so cleaning it up + merging sounds good.


Note: you can also access your agent directly at:
You can also access your agent directly at:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section feels redundant. I don't think we need to both provide a direct link to the dev console, and also tell people how to go to the front door of the dev console and then click through it.

TODO could we just include a simple web page in the template code that can be served up locally?

_TODO Matt: need to figure out if we add this or not_
> TODO(matt): Figure out what the right thing to do here is.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would punt on this for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok removing the part about embedding for now. opened issue #284 to track the work for doing this in future.

@benlower
Copy link
Contributor

i folded all these changes in via a diff PR

@benlower benlower closed this Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants