Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .travis.yml #25

Closed
wants to merge 8 commits into from
Closed

Update .travis.yml #25

wants to merge 8 commits into from

Conversation

paladox
Copy link

@paladox paladox commented Oct 25, 2015

No description provided.

@paladox
Copy link
Author

paladox commented Oct 25, 2015

I am not sure how to fix these errors. Could someone fix them please.

@paladox
Copy link
Author

paladox commented Oct 25, 2015

It causes other repos that depend on this repo to fail.

@paladox
Copy link
Author

paladox commented Oct 25, 2015

Could I have help to fix errors please. I am not sure what to change that code to.

@houli
Copy link
Contributor

houli commented Oct 25, 2015

The problem is not with the parts you changed in the calls to Path.exists. The problem is calling Path.exists. This function was marked deprecated because the exists function was moved from the path module to the fs module. In node 0.12 the deprecated function was removed.
One way to make sure this works in old and new versions of node is shown here https://github.com/fjakobs/async.js/blob/master/lib/plugins/fs-node.js#L12
All the places where Path.exists should have been updated when this code was written but clearly the code in the tests wasn't.

@houli
Copy link
Contributor

houli commented Oct 25, 2015

I've created a pull request here to fix these tests not passing and to also run CI tests against the latest four versions of node. #27

@paladox
Copy link
Author

paladox commented Oct 25, 2015

Thanks.

@fjakobs
Copy link
Owner

fjakobs commented Oct 27, 2015

this this PR still needed?

@paladox
Copy link
Author

paladox commented Oct 27, 2015

#28

@paladox paladox closed this Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants