Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADX-1046 No longer need _dont_validate context param #111

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

jonathansberry
Copy link
Member

Description

The _dont_validate context param appears to have only been used to avoid triggering package validation when patching the package with the finalised validation_status.

Since we have properly implemented a change to avoid metadata changes triggering package validation, this is no longer needed. Context params like this are a bit dodgy and it is best to clean it up if we can.

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.

@jonathansberry jonathansberry merged commit 7b711de into development Jan 3, 2024
4 checks passed
@jonathansberry jonathansberry deleted the ADX-1046-validation-triggering branch January 3, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants