Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADX-949 revert how foreign keys are handled #60

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

ChasNelson1990
Copy link
Member

Description

As detailed in fjelltopp/ckanext-validation#103 and related PRs I fundamentally changed how foreign keys are denoted - at the time this felt like the only solution that was a) general, and so could be pushed upstream, and b) worked with only a minor change to our current approach. However, yesterday it suddenly dawned on me that this actually completely broke our current approach.

The attached is a patch that reimplements some logic from our old fork to solve this problem.

relates fjelltopp/ckanext-validation#105

Checklist

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.

@ChasNelson1990 ChasNelson1990 self-assigned this Aug 15, 2023
@ChasNelson1990 ChasNelson1990 added the bug Something isn't working label Aug 15, 2023
@ChasNelson1990
Copy link
Member Author

@tomeksabala - this indirectly impacts the 2024 country estimates (the package schema is pointing to files that have been updated in this PR)

@ChasNelson1990 ChasNelson1990 merged commit de30a7e into development Aug 16, 2023
@ChasNelson1990 ChasNelson1990 deleted the fix-breaking-change branch August 16, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants