ADX-949 revert how foreign keys are handled #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As detailed in fjelltopp/ckanext-validation#103 and related PRs I fundamentally changed how foreign keys are denoted - at the time this felt like the only solution that was a) general, and so could be pushed upstream, and b) worked with only a minor change to our current approach. However, yesterday it suddenly dawned on me that this actually completely broke our current approach.
The attached is a patch that reimplements some logic from our old fork to solve this problem.
relates fjelltopp/ckanext-validation#105
Checklist