Skip to content

Commit

Permalink
Fix mtls credentials warning (#558)
Browse files Browse the repository at this point in the history
* fix warning in mtls credential case
* add line for multiproc dir in quickstart documentation
  • Loading branch information
djkhl authored Apr 4, 2024
1 parent 8258bdc commit eacb5f2
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
9 changes: 9 additions & 0 deletions doc/source/getting_started.rst
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,15 @@ Run without Logprep Container (default)
.. code-block:: bash
logprep run quickstart/exampledata/config/pipeline.yml
If logprep is run with the metrics enabled, the necessary environment variable has to be set first:

.. code-block:: bash
export PROMETHEUS_MULTIPROC_DIR="tmp/logprep"
logprep run quickstart/exampledata/config/pipeline.yml
Run with Logprep Container
Expand Down
4 changes: 2 additions & 2 deletions logprep/util/credentials.py
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ def _match_credentials(cls, credential_mapping: dict) -> "Credentials":
}:
if extra_params:
cls._logger.warning(
"Other parameters were given: %s but OAuth token authorization was chosen",
"Other parameters were given: %s but mTLS authorization was chosen",
extra_params.keys(),
)
return MTLSCredentials(client_key=client_key, cert=cert, ca_cert=ca_cert)
Expand All @@ -261,7 +261,7 @@ def _match_credentials(cls, credential_mapping: dict) -> "Credentials":
}:
if extra_params:
cls._logger.warning(
"Other parameters were given: %s but OAuth token authorization was chosen",
"Other parameters were given: %s but mTLS authorization was chosen",
extra_params.keys(),
)
return MTLSCredentials(client_key=client_key, cert=cert)
Expand Down

0 comments on commit eacb5f2

Please sign in to comment.