Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove process_strategy and mermaid #451

Merged
merged 8 commits into from
Oct 11, 2023
Merged

remove process_strategy and mermaid #451

merged 8 commits into from
Oct 11, 2023

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Oct 7, 2023

Removal of ProcessorStrategy

  • implements additional complexity
  • since implementation no other strategy was implemented
  • seems to be not needed

Removal of Mermaid from docs

  • diagrams are pretty old
  • mermaid does not work in airgapped environments

@ekneg54 ekneg54 changed the title Refactoring and Removements remove process_strategy and mermaid Oct 7, 2023
@ekneg54 ekneg54 requested a review from ppcad October 7, 2023 11:28
@ekneg54 ekneg54 marked this pull request as ready for review October 7, 2023 11:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (37e2a4d) 92.28% compared to head (c11cf4b) 92.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
+ Coverage   92.28%   92.36%   +0.07%     
==========================================
  Files         135      134       -1     
  Lines        9553     9531      -22     
==========================================
- Hits         8816     8803      -13     
+ Misses        737      728       -9     
Files Coverage Δ
logprep/abc/processor.py 99.40% <100.00%> (+0.08%) ⬆️
logprep/run_logprep.py 89.47% <100.00%> (-0.21%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekneg54 ekneg54 self-assigned this Oct 7, 2023
@ekneg54 ekneg54 marked this pull request as draft October 7, 2023 14:06
@ekneg54 ekneg54 marked this pull request as ready for review October 7, 2023 15:53
@ekneg54 ekneg54 added the refactoring only refactoring, no change in behavior label Oct 7, 2023
@ekneg54 ekneg54 merged commit d825a1c into main Oct 11, 2023
10 checks passed
@ekneg54 ekneg54 deleted the refactor-things branch October 11, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring only refactoring, no change in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants