-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove MultiprocessLogHandler #455
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
==========================================
+ Coverage 92.00% 92.07% +0.07%
==========================================
Files 133 132 -1
Lines 9439 9389 -50
==========================================
- Hits 8684 8645 -39
+ Misses 755 744 -11
☔ View full report in Codecov by Sentry. |
ekneg54
force-pushed
the
fix-multiprocess-logging
branch
from
October 9, 2023 15:34
bda3999
to
e7c4540
Compare
ppcad
requested changes
Oct 11, 2023
ekneg54
force-pushed
the
fix-multiprocess-logging
branch
from
October 11, 2023 09:33
e7c4540
to
9137b30
Compare
done it ... plz have a look again. Thank you. |
ppcad
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the MultiprocessLogHandler in favor of using the QueueHandler and QueueListener (see: https://docs.python.org/3/library/logging.handlers.html#queuehandler)