Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove MultiprocessLogHandler #455

Merged
merged 3 commits into from
Oct 11, 2023
Merged

remove MultiprocessLogHandler #455

merged 3 commits into from
Oct 11, 2023

Conversation

ekneg54
Copy link
Collaborator

@ekneg54 ekneg54 commented Oct 7, 2023

This removes the MultiprocessLogHandler in favor of using the QueueHandler and QueueListener (see: https://docs.python.org/3/library/logging.handlers.html#queuehandler)

@ekneg54 ekneg54 self-assigned this Oct 7, 2023
@ekneg54 ekneg54 added the refactoring only refactoring, no change in behavior label Oct 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d825a1c) 92.00% compared to head (9137b30) 92.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   92.00%   92.07%   +0.07%     
==========================================
  Files         133      132       -1     
  Lines        9439     9389      -50     
==========================================
- Hits         8684     8645      -39     
+ Misses        755      744      -11     
Files Coverage Δ
logprep/abc/processor.py 99.41% <ø> (ø)
logprep/framework/pipeline.py 97.92% <100.00%> (+0.70%) ⬆️
logprep/framework/pipeline_manager.py 100.00% <100.00%> (ø)
logprep/run_logprep.py 89.40% <ø> (-0.07%) ⬇️
logprep/runner.py 95.48% <100.00%> (-1.04%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekneg54 ekneg54 marked this pull request as ready for review October 8, 2023 17:21
@ekneg54 ekneg54 requested a review from ppcad October 8, 2023 17:22
@ekneg54 ekneg54 force-pushed the fix-multiprocess-logging branch from bda3999 to e7c4540 Compare October 9, 2023 15:34
logprep/framework/pipeline_manager.py Outdated Show resolved Hide resolved
tests/acceptance/util.py Show resolved Hide resolved
@ekneg54 ekneg54 force-pushed the fix-multiprocess-logging branch from e7c4540 to 9137b30 Compare October 11, 2023 09:33
@ekneg54 ekneg54 requested a review from ppcad October 11, 2023 09:37
@ekneg54
Copy link
Collaborator Author

ekneg54 commented Oct 11, 2023

done it ... plz have a look again.

Thank you.

Copy link
Collaborator

@ppcad ppcad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me!

@ekneg54 ekneg54 merged commit 9458a24 into main Oct 11, 2023
10 checks passed
@ekneg54 ekneg54 deleted the fix-multiprocess-logging branch October 11, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring only refactoring, no change in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants