Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-compile patterns, add cache and support ignoring case in generic resolver #716

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Pre-compile patterns, add cache and support ignoring case in generic resolver #716

merged 7 commits into from
Dec 5, 2024

Conversation

ppcad
Copy link
Collaborator

@ppcad ppcad commented Dec 2, 2024 •
edited
Loading

No description provided.

@ppcad ppcad self-assigned this Dec 2, 2024
@ppcad ppcad requested a review from dtrai2 December 2, 2024 13:02
@ppcad ppcad marked this pull request as ready for review December 2, 2024 13:02
dtrai2
dtrai2 requested changes Dec 4, 2024
View reviewed changes
logprep/processor/generic_resolver/processor.py Outdated Show resolved Hide resolved
logprep/processor/generic_resolver/processor.py Outdated Show resolved Hide resolved
logprep/processor/generic_resolver/processor.py Outdated Show resolved Hide resolved
logprep/processor/generic_resolver/processor.py Outdated Show resolved Hide resolved
logprep/processor/generic_resolver/processor.py Outdated Show resolved Hide resolved
logprep/processor/generic_resolver/rule.py Show resolved Hide resolved
logprep/processor/generic_resolver/rule.py Outdated Show resolved Hide resolved
logprep/processor/generic_resolver/rule.py Outdated Show resolved Hide resolved
tests/unit/processor/generic_resolver/test_generic_resolver.py Show resolved Hide resolved
tests/unit/processor/generic_resolver/test_generic_resolver.py Outdated Show resolved Hide resolved
@ppcad ppcad requested a review from dtrai2 December 5, 2024 07:27
dtrai2
dtrai2 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@dtrai2 dtrai2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the implemented suggestions! 👍

@ppcad ppcad merged commit 4219101 into main Dec 5, 2024
13 checks passed
@ppcad ppcad mentioned this pull request Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtrai2 dtrai2 dtrai2 approved these changes

Assignees

@ppcad ppcad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppcad @dtrai2