Fix FieldsExist warning using LOGPREP_APPEND_MEASUREMENT_TO_EVENT
#725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this fixes a FieldExist warning which was thrown when processing times of a rule where already present in the event - recreates previous behavior before #696 was merged
ppcad
approved these changes
Dec 11, 2024
ekneg54
deleted the
721-enabling-appending-time-measurements-to-events-can-cause-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering that the feature
LOGPREP_APPEND_MEASUREMENT_TO_EVENTwill be removed in the future I decided to just recreate the previous behavior. Before #696 was merged it was ignored if the value was already present or not. I ensured here now that the same behavior is happing again, by using_add_field_to_silent_fail. It is to note though that this means, that only the first processor/rule of a kind will write it's processing times into the event. Consecutive processors/rules of the same type will then be ignored.closes #721