Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce to one rule tree #731

Merged
merged 13 commits into from
Dec 20, 2024
Merged

reduce to one rule tree #731

merged 13 commits into from
Dec 20, 2024

Conversation

ppcad
Copy link
Collaborator

@ppcad ppcad commented Dec 17, 2024

No description provided.

@ppcad ppcad self-assigned this Dec 17, 2024
@ppcad ppcad linked an issue Dec 17, 2024 that may be closed by this pull request
Remove second rule tree #728
Closed
@ppcad ppcad changed the title Reduce to one rule tree reduce to one rule tree Dec 17, 2024
@ppcad ppcad requested review from dtrai2 and ekneg54 December 18, 2024 10:31
@ppcad ppcad requested a review from djkhl December 18, 2024 10:57
@ppcad ppcad marked this pull request as ready for review December 18, 2024 11:02
dtrai2
dtrai2 requested changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@dtrai2 dtrai2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for the diligent work! Quite a feat. It'll take out unnecessary the complexity.

I only found some tiny things you can still remove. Also in the following two files I found references to generic and specific rules:

  • rule.py line 20 & 21
  • test_full_configuration.py line 237 and 242

tests/unit/processor/dropper/test_dropper.py Outdated Show resolved Hide resolved
tests/unit/processor/domain_label_extractor/test_domain_label_extractor.py Outdated Show resolved Hide resolved
tests/unit/processor/datetime_extractor/test_datetime_extractor.py Outdated Show resolved Hide resolved
tests/unit/processor/concatenator/test_concatenator.py Outdated Show resolved Hide resolved
tests/unit/processor/generic_adder/test_generic_adder.py Outdated Show resolved Hide resolved
tests/unit/processor/generic_resolver/test_generic_resolver.py Outdated Show resolved Hide resolved
tests/unit/processor/geoip_enricher/test_geoip_enricher.py Outdated Show resolved Hide resolved
tests/unit/processor/labeler/test_labeler.py Outdated Show resolved Hide resolved
tests/unit/processor/template_replacer/test_template_replacer.py Outdated Show resolved Hide resolved
@ppcad
Copy link
Collaborator Author

ppcad commented Dec 19, 2024

Ah thanks for the diligent work! Quite a feat. It'll take out unnecessary the complexity.

I only found some tiny things you can still remove. Also in the following two files I found references to generic and specific rules:

  • rule.py line 20 & 21
  • test_full_configuration.py line 237 and 242

Thank you for the review, I've changed it.

@ppcad ppcad requested a review from dtrai2 December 19, 2024 07:07
@dtrai2 dtrai2 merged commit 73dbdf6 into main Dec 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtrai2 dtrai2 dtrai2 approved these changes

@ekneg54 ekneg54 Awaiting requested review from ekneg54

@djkhl djkhl Awaiting requested review from djkhl

Assignees

@ppcad ppcad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove second rule tree
2 participants
@ppcad @dtrai2