Make sure replaced instructions are added after phi instructions

fkie-cad · Feb 8, 2024 · 1bfe6dd · 1bfe6dd
1 parent 96eadd7
commit 1bfe6dd
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/decompiler/pipeline/commons/expressionpropagationcommons.py b/decompiler/pipeline/commons/expressionpropagationcommons.py
@@ -85,10 +85,8 @@ def _remove_redundant_phis(self, graph: ControlFlowGraph) -> bool:
                 if not all_equal(instruction.value.operands):
                     continue
 
-                basic_block.replace_instruction(
-                    instruction,
-                    Assignment(instruction.destination, instruction.value.operands[0])
-                )
+                basic_block.remove_instruction(index)
+                basic_block.add_instruction_where_possible(Assignment(instruction.destination, instruction.value.operands[0]))
                 changes |= True
         return changes