[AttributeError@constant_folding.py:137] AttributeError: 'UnknownType…

…' object has no attribute 'signed' (#358) * Create draft PR for #357 * Fix incorrect signed check * Change syntax in constant_folding.py --------- Co-authored-by: rihi <[email protected]> Co-authored-by: rihi <[email protected]>
fkie-cad · Nov 16, 2023 · 4acb7f0 · 4acb7f0
1 parent 0ff5502
commit 4acb7f0
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/decompiler/pipeline/controlflowanalysis/expression_simplification/constant_folding.py b/decompiler/pipeline/controlflowanalysis/expression_simplification/constant_folding.py
@@ -133,8 +133,9 @@ def _constant_fold_shift(constants: list[Constant], fun: Callable[[int, int], in
         raise IncompatibleOperandCount("Expected exactly 2 constants to fold")
 
     left, right = constants
+    norm_signed = signed and isinstance(left.type, Integer) and left.type.signed
 
-    return fun(normalize_int(left.value, left.type.size, left.type.signed and signed), right.value)
+    return fun(normalize_int(left.value, left.type.size, norm_signed), right.value)
 
 
 _OPERATION_TO_FOLD_FUNCTION: dict[OperationType, Callable[[list[Constant]], int]] = {