close CloseableNamedTemporaryFile before removing

fkie-cad · Dec 7, 2023 · 68115dd · 68115dd
1 parent f81eddf
commit 68115dd
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/decompiler/util/closeable_named_temporary_file.py b/decompiler/util/closeable_named_temporary_file.py
@@ -20,4 +20,10 @@ def CloseableNamedTemporaryFile(**kwargs):
         try:
             yield file
         finally:
+            # Close the file to be sure that it can be removed.
+            # It's ok if the file was already closed because NamedTemporaryFile's close method is idempotent.
+            file.close()
+            # If file was already deleted outside of this contextmanager, this will crash
+            # (just like the original NamedTemporaryFile).
+            # On NT, this might also crash if another handle to this file is still open
             os.remove(file.name)