Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Structure type] Improve current structure type support #253

Merged
merged 27 commits into from
Sep 7, 2023
Merged

[Structure type] Improve current structure type support #253

merged 27 commits into from
Sep 7, 2023

Conversation

github-actions[bot]
Copy link
Contributor

closes #252

@github-actions github-actions bot added the feature-request New feature or request label Jun 14, 2023
@mari-mari mari-mari force-pushed the issue-252-_Structure_type_Improve_current_structure_type_support branch from a278f9e to 54cc7fd Compare June 20, 2023 13:20
@mari-mari mari-mari force-pushed the issue-252-_Structure_type_Improve_current_structure_type_support branch 2 times, most recently from 499e3e9 to 081d0ee Compare July 7, 2023 08:30
@mari-mari mari-mari force-pushed the issue-252-_Structure_type_Improve_current_structure_type_support branch 4 times, most recently from 9623e9f to 13d274b Compare July 21, 2023 11:10
@mari-mari mari-mari force-pushed the issue-252-_Structure_type_Improve_current_structure_type_support branch 3 times, most recently from da04912 to 2ea6a47 Compare August 14, 2023 14:56
@mari-mari mari-mari marked this pull request as ready for review August 15, 2023 12:34
@mari-mari mari-mari force-pushed the issue-252-_Structure_type_Improve_current_structure_type_support branch from 2919893 to e680e3f Compare August 15, 2023 12:47
@mari-mari mari-mari requested a review from 0x6e62 August 23, 2023 08:10
0x6e62
0x6e62 requested changes Aug 24, 2023
View reviewed changes
decompiler/backend/cexpressiongenerator.py Outdated Show resolved Hide resolved
decompiler/frontend/binaryninja/parser.py Outdated Show resolved Hide resolved
decompiler/task.py Outdated Show resolved Hide resolved
decompiler/frontend/binaryninja/frontend.py Outdated Show resolved Hide resolved
decompiler/frontend/binaryninja/frontend.py Outdated Show resolved Hide resolved
decompiler/frontend/binaryninja/handlers/assignments.py Outdated Show resolved Hide resolved
decompiler/frontend/binaryninja/handlers/assignments.py Show resolved Hide resolved
@mari-mari mari-mari force-pushed the issue-252-_Structure_type_Improve_current_structure_type_support branch from c3c790a to d426039 Compare August 28, 2023 07:42
0x6e62
0x6e62 requested changes Aug 29, 2023
View reviewed changes
decompiler/frontend/binaryninja/handlers/assignments.py Show resolved Hide resolved
decompiler/frontend/binaryninja/handlers/assignments.py Outdated Show resolved Hide resolved
decompiler/frontend/binaryninja/handlers/unary.py Outdated Show resolved Hide resolved
decompiler/frontend/binaryninja/handlers/unary.py Outdated Show resolved Hide resolved
decompiler/frontend/binaryninja/handlers/types.py Show resolved Hide resolved
decompiler/structures/pseudo/complextypes.py Outdated Show resolved Hide resolved
decompiler/structures/pseudo/complextypes.py Show resolved Hide resolved
decompiler/structures/pseudo/complextypes.py Show resolved Hide resolved
tests/structures/pseudo/test_complextypes.py Outdated Show resolved Hide resolved
tests/test_sample_binaries.py Show resolved Hide resolved
@mari-mari mari-mari force-pushed the issue-252-_Structure_type_Improve_current_structure_type_support branch from d7d79f4 to 4938c8d Compare September 7, 2023 08:43
@mari-mari @0x6e62
Clean up structs code generation, use accept/visit of unary operation
b8f85e3
@mari-mari @0x6e62
Fix lifting of unions, add complex type width, refactor
8196d34
@mari-mari @0x6e62
Rename StructMemberAccess to MemberAccess, remove unused methods, add…
7f81265 
… tests for complex types and member access
@mari-mari @0x6e62
Fix forgot git add
9d41ffe
@mari-mari @0x6e62
Add member access tests for code generation
e2a68bd
@mari-mari @0x6e62
Fix too much semicolons in declarations
4095e7a
@mari-mari @0x6e62
Fix trying to get parent type of non-complex-type-varible
e586bee
@mari-mari @0x6e62
Start cleanup
145d559
@mari-mari @0x6e62
Continue cleanup
a8b1711
@mari-mari @0x6e62
Continue cleanup
49fd05d
@mari-mari @0x6e62
Continue cleanup
dc8fd48
@mari-mari @0x6e62
Fix adding ; in case complex type is empty breaks code generation tod…
ad7567a 
…o test that in code generation
@mari-mari @0x6e62
Remove todos
c202e8c
@mari-mari @0x6e62
Add review changes
607b4d1
@mari-mari @0x6e62
Fix isort errors, add test to check member access in decompiler output
201b2e0
@mari-mari @0x6e62
MR changes
822f5f0
@mari-mari @0x6e62
Add mr review change
fb0ad27
@0x6e62 0x6e62 force-pushed the issue-252-_Structure_type_Improve_current_structure_type_support branch from 620c5e1 to fb0ad27 Compare September 7, 2023 09:06
@0x6e62 0x6e62 merged commit d4b9357 into main Sep 7, 2023
@0x6e62 0x6e62 deleted the issue-252-_Structure_type_Improve_current_structure_type_support branch September 7, 2023 10:01
@rihi rihi mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mari-mari mari-mari mari-mari left review comments

@0x6e62 0x6e62 0x6e62 approved these changes

Assignees

@mari-mari mari-mari

Labels
feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Structure type] Improve current structure type support
2 participants
@mari-mari @0x6e62