Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move For/While renaming into own stage #316

Merged
merged 10 commits into from
Sep 26, 2023
Merged

Move For/While renaming into own stage #316

merged 10 commits into from
Sep 26, 2023

Conversation

github-actions[bot]
Copy link
Contributor

closes #315

@github-actions github-actions bot added the feature-request New feature or request label Aug 15, 2023
@NeoQuix
Copy link
Collaborator

NeoQuix commented Aug 15, 2023

Don't know exactly how you prefer the "mixed methods".
Moved all methods which both stages use (all _ methods which use AST_INSTRUCTIONS) into own file (without a folder).

If the name/location is not sufficient, just move the file + fix imports

@NeoQuix NeoQuix mentioned this pull request Aug 15, 2023
Closed
@NeoQuix NeoQuix marked this pull request as ready for review August 17, 2023 08:07
@steffenenders steffenenders self-requested a review August 24, 2023 08:53
steffenenders
steffenenders previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@steffenenders steffenenders left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Edit: Can be merged once the conflicts are resolved.

@NeoQuix
Copy link
Collaborator

NeoQuix commented Aug 31, 2023

Miss clicked the correct merge of test_readability, fixed them manually with the commit afterwards.
Should be correct is pipeline runs successfully.

@steffenenders steffenenders merged commit 455cecb into main Sep 26, 2023
@steffenenders steffenenders deleted the issue-315-Move_For/While_renaming_into_own_stage branch September 26, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenenders steffenenders steffenenders left review comments

Assignees

@NeoQuix NeoQuix

Labels
feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move For/While renaming into own stage
2 participants
@NeoQuix @steffenenders