-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hungarian Notation] Variables with different names but same labels are renamed to the same variable. #317
Conversation
To decide:
|
Also: Substitute variables in a batch (dictionary) instead of iterating over AST every time |
Will only go once through the whole tree, but will still call n times replace_variable for all n replacement pairs in the nodes. If the nodes would know the variables in their instructions, it could be faster. |
decompiler/pipeline/controlflowanalysis/variable_name_generation.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/variable_name_generation.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/variable_name_generation.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/variable_name_generation.py
Outdated
Show resolved
Hide resolved
0be5830
to
20facab
Compare
Rebase onto main. |
Removing old review because of too much changes. |
tests/pipeline/controlflowanalysis/test_variable_name_generation.py
Outdated
Show resolved
Hide resolved
* Copy variables when renaming * Fix: ArrayType,config,tests * Fix: Prefix+Arrays * Fix: Custom test --------- Co-authored-by: rihi <[email protected]> Co-authored-by: Spartak Ehrlich <[email protected]>
a8d6d85
to
c068b60
Compare
…_different_names_but_same_labels_are_renamed_to_the_same_variable
closes #309