[For-Loop Reconstruction] Follow up: Not handling "continue" instructions correctly #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ebehner
requested changes
Oct 4, 2023
decompiler/pipeline/controlflowanalysis/readability_based_refinement.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/readability_based_refinement.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/readability_based_refinement.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/readability_based_refinement.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/readability_based_refinement.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/readability_based_refinement.py
Outdated
Show resolved
Hide resolved
tests/pipeline/controlflowanalysis/test_readability_based_refinement.py
Outdated
Show resolved
Hide resolved
tests/pipeline/controlflowanalysis/test_readability_based_refinement.py
Outdated
Show resolved
Hide resolved
ebehner
reviewed
Oct 19, 2023
decompiler/pipeline/controlflowanalysis/readability_based_refinement.py
Outdated
Show resolved
Hide resolved
…_Not_handling_continue_instructions_correctly
ebehner
requested changes
Nov 23, 2023
decompiler/pipeline/controlflowanalysis/readability_based_refinement.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/loop_utility_methods.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/loop_utility_methods.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/loop_utility_methods.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/loop_utility_methods.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/loop_utility_methods.py
Outdated
Show resolved
Hide resolved
ebehner
reviewed
Dec 18, 2023
decompiler/pipeline/controlflowanalysis/loop_utility_methods.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/loop_utility_methods.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/loop_utility_methods.py
Outdated
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/loop_utility_methods.py
Outdated
Show resolved
Hide resolved
…_Not_handling_continue_instructions_correctly
ebehner
approved these changes
Dec 21, 2023
ebehner
deleted the
issue-325-_For-Loop_Reconstruction_Follow_up_Not_handling_continue_instructions_correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #325