Adjust code generation for the function pointer type. #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ction_pointer_type
mari-mari
requested changes
Sep 6, 2023
| """ Return a string representation of variable declarations.""" | ||
| match var_type: | ||
| case Pointer(type=FunctionTypeDef() as fun_type): | ||
| rest = ", ".join(map(lambda n: f"(* {n})({', '.join(str(x) for x in fun_type.parameters)})", var_names)) |
There was a problem hiding this comment.
- Could you please use more meaningful name than
rest? - One-liner here is hard to understand. Could you please come up with more readable code here?
There was a problem hiding this comment.
Sure, I've split the one-liner up into multiple lines with more descriptive variable names.
mari-mari
approved these changes
Sep 7, 2023
mari-mari
deleted the
issue-322-Adjust_code_generation_for_the_function_pointer_type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #322