Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AttributeError@constant_folding.py:137] AttributeError: 'UnknownType' object has no attribute 'signed' #358

Merged
merged 3 commits into from
Nov 16, 2023
Merged

[AttributeError@constant_folding.py:137] AttributeError: 'UnknownType' object has no attribute 'signed' #358

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b3a654
Create draft PR for #357
rihi Nov 8, 2023
7a02198
Fix incorrect signed check
rihi Nov 8, 2023
b67158d
Change syntax in constant_folding.py
rihi Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion decompiler/pipeline/controlflowanalysis/expression_simplification/constant_folding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,9 @@ def _constant_fold_shift(constants: list[Constant], fun: Callable[[int, int], in
raise IncompatibleOperandCount("Expected exactly 2 constants to fold")

left, right = constants
norm_signed = signed and isinstance(left.type, Integer) and left.type.signed

return fun(normalize_int(left.value, left.type.size, left.type.signed and signed), right.value)
return fun(normalize_int(left.value, left.type.size, norm_signed), right.value)


_OPERATION_TO_FOLD_FUNCTION: dict[OperationType, Callable[[list[Constant]], int]] = {
Expand Down
Loading