New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Quality] Remove wildcard import #371

Merged

steffenenders merged 1 commit into main from remove_wildcard_import

Nov 30, 2023

Collaborator

blattm commented Nov 29, 2023

This commit removes the wildcard import from .branches import * and replaces it with explicit imports.

Reasons to do so:

The wildcard import unnecessarily pollutes the namespace of cfg with all of branches imports.
The aforementioned pollution caused typecheckers and linters to partially fail because of weird side effects.
"Explicit is better than implicit" (The Zen of Python)


          remove wildcard import

84db0b6

blattm self-assigned this

steffenenders merged commit fcb7292 into main

steffenenders deleted the remove_wildcard_import branch

November 30, 2023 09:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet