-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lifter] Addresses representation in the decompiled code #397
Merged
blattm
merged 7 commits into
main
from
issue-52-_GUI_Addresses_representation_in_the_decompiled_code
Apr 17, 2024
Merged
[Lifter] Addresses representation in the decompiled code #397
blattm
merged 7 commits into
main
from
issue-52-_GUI_Addresses_representation_in_the_decompiled_code
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature-request
New feature or request
priority-low
Low priority issue
labels
Mar 13, 2024
fnhartmann
changed the title
[GUI] Addresses representation in the decompiled code
[Lifter] Addresses representation in the decompiled code
Mar 13, 2024
mari-mari
force-pushed
the
issue-52-_GUI_Addresses_representation_in_the_decompiled_code
branch
from
April 11, 2024 07:49
572bfb3
to
e6814c2
Compare
blattm
reviewed
Apr 16, 2024
@@ -3,7 +3,8 @@ | |||
import math | |||
from typing import Union | |||
|
|||
from binaryninja import DataVariable, SymbolType, Type, mediumlevelil | |||
from binaryninja import BinaryView, DataVariable, SymbolType, Type, mediumlevelil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove unused import again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
blattm
approved these changes
Apr 17, 2024
blattm
deleted the
issue-52-_GUI_Addresses_representation_in_the_decompiled_code
branch
April 17, 2024 06:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #52