Fix ordering of inserted common subexpressions #403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common subexpression elimination stage currently has a bug, where if multiple eliminated subexpressions depend on each other are inserted in the wrong order into a basic block.
This can result in transformation like this:
This is caused by us caching the index of each instruction in the
CfgInstruction
class and not updating it after inserting new definitions. This PR simply changes this so that the index is always calculated instead of being cached. While theoretically this has worse performance, the extend tests runtime only increased from 10:42 to 11:13 on my machine.