Drop dependency on fact_helper_file #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maringuu
force-pushed
the
drop-fact-helper-file
branch
from
d5b3635 to
a003405
Compare
|
Converting to draft as we must somehow tell pytest that it should execute the tests with the proper MAGIC variable. |
jstucke
reviewed
Aug 15, 2024
maringuu
force-pushed
the
drop-fact-helper-file
branch
2 times, most recently
from
b98ee6b to
a092f9b
Compare
maringuu
force-pushed
the
drop-fact-helper-file
branch
from
a092f9b to
f7a3446
Compare
maringuu
force-pushed
the
drop-fact-helper-file
branch
2 times, most recently
from
9bea21a to
b965800
Compare
2 tasks
This allows us to properly import the extractor via `import fact_extract` rather than importing all submodules individually. Also this is most definitely more correct.
Not telling the user which modules failed is arguably worse than just erroring out with the ImportError
As the python interpreter only adds the parent directory of the executed script as module search path and we depend on `fact_extractor` the file must be placed next to the `fact_extractor` module.
Despite us using ADD, the gitignore does not seem to be honored
Previously we had three different startup scripts: - The docker entrypoint (fact_extractor/docker_extract.py) - The python module entrypoint (fact_extractor/fact_extract.py) - The docker wrapper (extract.py) This commit removes the docker entrypoint and moves the module entrypoint to __main__.py while changing as little code as possible.
maringuu
force-pushed
the
drop-fact-helper-file
branch
from
b965800 to
9ee65bb
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Related fkie-cad/FACT_core#1140