Fix English translations not used despite being preferred #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When specifying the preferred language on Linux, the $LANGUAGE env var is used. https://www.gnu.org/software/gettext/manual/html_node/The-LANGUAGE-variable.html Example: $ LANGUAGE=en:nl flameshot Expected: flameshot should be in English as this is a localization that flameshot provides. If English would not be supported, it should fall back to using Dutch (nl). Actual: flameshot uses Dutch translations. Cause: If an empty translation file for "en" is not provided, English is only used as a fallback. See https://bugreports.qt.io/browse/QTBUG-69196
|
Thank you for the PR and the detailed explanations. Looks good to me. Let's just wait for one more dev to review the PR too. |
mmahmoudian
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying the preferred language on Linux, the
$LANGUAGEenv var is used. See https://www.gnu.org/software/gettext/manual/html_node/The-LANGUAGE-variable.html.Example:
$ LANGUAGE=en:nl flameshotExpected:
flameshot should be in English as this is a localization that flameshot provides. If English would not be supported, it should fall back to using Dutch (nl).
Actual:
flameshot uses Dutch translations.
Cause:
If an empty translation file for the base language (here "en") is not provided, the base language is only used as a fallback.
See https://bugreports.qt.io/browse/QTBUG-69196
Additional search keywords: