fix: better deletion of resources #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshloop
reviewed
Apr 15, 2024
adityathebe
force-pushed
the
fix/kubernetes-resource-check-deletion
branch
2 times, most recently
from
ff2cec9 to
5afd161
Compare
moshloop
reviewed
Apr 16, 2024
adityathebe
force-pushed
the
fix/kubernetes-resource-check-deletion
branch
2 times, most recently
from
238f163 to
6c49c90
Compare
moshloop
reviewed
Apr 18, 2024
|
@adityathebe I don't think we need a waitFor.maxRetries as we have a timeout, and the docs for the default on interval say 30s instead of 5s |
adityathebe
force-pushed
the
fix/kubernetes-resource-check-deletion
branch
from
6bac1f7 to
6617ff8
Compare
optional. * add another option to delete the resources in case they already exist
adityathebe
force-pushed
the
fix/kubernetes-resource-check-deletion
branch
from
6617ff8 to
25c4266
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #1782