Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new functions to cel-go docs #109

Merged
merged 2 commits into from
Dec 17, 2023
Merged

feat: add new functions to cel-go docs #109

merged 2 commits into from
Dec 17, 2023

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented Dec 14, 2023 •
edited
Loading

resolves: #106

@netlify Netlify
Copy link

netlify bot commented Dec 14, 2023 •
edited
Loading

✅ Deploy Preview for canarychecker ready!

Name Link
🔨 Latest commit 901c1d8
🔍 Latest deploy log https://app.netlify.com/sites/canarychecker/deploys/657ec2ce485fa40007f50103
😎 Deploy Preview https://deploy-preview-109--canarychecker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 14, 2023 •
edited
Loading

✅ Deploy Preview for flanksource-docs canceled.

Name Link
🔨 Latest commit 901c1d8
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-docs/deploys/657ec2ce68601b0008b0c26d

@adityathebe adityathebe force-pushed the feat/cel-docs branch 5 times, most recently from 4061d0d to 4b6e0d1 Compare December 14, 2023 11:01
@adityathebe
feat: add new functions to cel-go docs
7ea0b1e 
* format the markdown as well
@adityathebe adityathebe requested a review from moshloop December 14, 2023 11:06
@adityathebe
Copy link
Member Author

@moshloop Should we remove functions that are already methods?

Eg: toJSON, JSON, JSONArray.

I think we could also remove humanDuration/humanSize since we already have HumanDuration/HumanSize. From what I am seeing, we can go with the convention of

  • methods -> camel case
  • functions -> Pascal case

Also we could namespace the aws and k8s functions. k8s.GetStatus instead of GetStatus

@adityathebe adityathebe requested a review from moshloop December 15, 2023 13:29
@adityathebe
chore: format expression blocks
901c1d8 
* separate into single expression per block
* comment out plain texts
@moshloop moshloop merged commit f562fcc into main Dec 17, 2023
3 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.36 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@adityathebe adityathebe deleted the feat/cel-docs branch December 17, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshloop moshloop Awaiting requested review from moshloop

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CEL docs
2 participants
@adityathebe @moshloop