prepare for duty migration in canary checker #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
commented
May 2, 2023
| @@ -76,17 +67,17 @@ type Component struct { | |||
| Parents []string `json:"parents,omitempty" gorm:"-"` | |||
| } | |||
|
|
|||
| func (c *Component) GetStatus() ComponentStatus { | |||
| func (c *Component) GetStatus() types.ComponentStatus { | |||
There was a problem hiding this comment.
Thought I would just use GetStatus() method from Summary
func (c *Component) GetStatus() types.ComponentStatus {
return c.Summary.GetStatus()
}but they have different logics. Not sure if it's correct to do it this way.
There was a problem hiding this comment.
Here, I see that component's status is being set using Summary's GetStatus method
https://github.com/flanksource/canary-checker/blob/master/pkg/topology/run.go#L399
There was a problem hiding this comment.
Hmm, not sure about it. @moshloop Can you chime in here
yashmehrotra
reviewed
May 3, 2023
yashmehrotra
reviewed
May 3, 2023
yashmehrotra
reviewed
May 3, 2023
yashmehrotra
reviewed
May 3, 2023
yashmehrotra
reviewed
May 3, 2023
adityathebe
force-pushed
the
component-migration
branch
from
4fd7266 to
1921f88
Compare
Replace types.JSON with ConfigQuery in Component struct [skip ci]
* Remove config: null from fixture
* Use Generic struct scan and value wherever it was missed.
adityathebe
force-pushed
the
component-migration
branch
from
63eb38f to
02ff4d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new methods and some refactoring to help with flanksource/canary-checker#794