fix: add deduplication in topology #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmehrotra
commented
Nov 3, 2023
query/topology.go
Outdated
Comment on lines
94
to
97
| if !opt.nonDirectChildrenOnly { | ||
| s += " AND component_relationships.component_id = NULL" | ||
| s += " AND component_relationships.component_id IS NULL" | ||
| } else { | ||
| s += " AND component_relationships.component_id IS NOT NULL" | ||
| s += " AND component_relationships.relationship_id IS NULL" | ||
| } |
There was a problem hiding this comment.
@adityathebe Let me know what these should be
yashmehrotra
commented
Nov 3, 2023
Comment on lines
-47
to
-69
| }, | ||
| { | ||
| "agent_id": "00000000-0000-0000-0000-000000000000", | ||
| "icon": "icon-kubernetes-pod", | ||
| "id": "018681ff-80ed-d10d-21ef-c74f152b085b", | ||
| "is_leaf": false, | ||
| "name": "logistics-api-574dc95b5d-mp64w", | ||
| "parent_id": "018681ff-559f-7183-19d1-7d898b4e1413", | ||
| "parents": [ | ||
| "018681fe-f5aa-37e9-83f7-47b5b0232d5e" | ||
| ], | ||
| "status": "healthy", | ||
| "summary": { | ||
| "healthy": 1 | ||
| }, | ||
| "type": "KubernetesPod" | ||
| }, | ||
| { | ||
| "agent_id": "00000000-0000-0000-0000-000000000000", | ||
| "icon": "icon-kubernetes-pod", | ||
| "id": "018681ff-b6c1-a14d-2fd4-8c7dac94cddd", | ||
| "is_leaf": false, | ||
| "name": "logistics-ui-676b85b87c-tjjcp", |
There was a problem hiding this comment.
@moshloop After the direct children change, there might be bugs/regressions which were copied over in some fixtures as well
For eg. here components are being repeated
yashmehrotra
force-pushed
the
refactor-topolgoy
branch
2 times, most recently
from
b71c49e to
de838df
Compare
yashmehrotra
force-pushed
the
refactor-topolgoy
branch
from
de838df to
dda620f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.