feat: crossplane health checks

pkg/health/health.go

@@ -1,6 +1,8 @@
 package health
 
 import (
+	"strings"
+
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime/schema"
 )
@@ -143,6 +145,11 @@ func GetHealthCheckFunc(gvk schema.GroupVersionKind) func(obj *unstructured.Unst
 	if gvk.Kind == "Node" {
 		return getNodeHealth
 	}
+
+	if strings.HasSuffix(gvk.Group, ".crossplane.io") || strings.HasSuffix(gvk.Group, ".upbound.io") {
+		return GetDefaultHealth
+	}
+
 	switch gvk.Group {
 	case "apps":
 		switch gvk.Kind {

pkg/health/health_cert_manager.go

@@ -51,17 +51,3 @@ func GetCertificateHealth(obj *unstructured.Unstructured) (*HealthStatus, error)
 
 	return status, nil
 }
-
-// Certificate:
-//   conditions:
-//     Ready:
-//       ready: true
-//       health: healthy
-//       status: Issued
-//       onFalse:
-//         status: Issuing
-//         health: unknown
-//       reasons:
-//         ConfigError:
-//           ready: true
-//           health: unhealthy

pkg/health/health_test.go

@@ -35,6 +35,10 @@ func getHealthStatus(yamlPath string, t *testing.T) *health.HealthStatus {
 	return health
 }
 
+func TestCrossplane(t *testing.T) {
+	assertAppHealth(t, "./testdata/crossplane.yaml", "Available", health.HealthHealthy, true)
+}
+
 func TestNamespace(t *testing.T) {
 	assertAppHealth(t, "./testdata/namespace.yaml", health.HealthStatusHealthy, health.HealthUnknown, true)
 	assertAppHealth(t, "./testdata/namespace-terminating.yaml", health.HealthStatusTerminating, health.HealthUnknown, false)

pkg/health/status.go

@@ -2,6 +2,7 @@ package health
 
 import (
 	_ "embed"
+	"strings"
 
 	"gopkg.in/yaml.v2"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -181,9 +182,17 @@ type StatusMap struct {
 const NoCondition = "none"
 
 func GetDefaultHealth(obj *unstructured.Unstructured) (*HealthStatus, error) {
+	kind := obj.GetKind()
+	group := strings.Split(obj.GetAPIVersion(), "/")[0]
+	if strings.HasSuffix(group, "crossplane.io") || strings.HasSuffix(group, "upbound.io") {
+		// For crossplane resources, we use a single status mapping under the dummy Kind "crossplane.io"
+		// that is supposed to cater for all the crossplane kinds.
+		kind = "crossplane.io"
+	}
+
 	if statusMap, ok := statusByKind[obj.GetAPIVersion()+"/"+obj.GetKind()]; ok {
 		return GetHealthFromStatus(GetGenericStatus(obj), statusMap)
-	} else if statusMap, ok := statusByKind[obj.GetKind()]; ok {
+	} else if statusMap, ok := statusByKind[kind]; ok {
 		return GetHealthFromStatus(GetGenericStatus(obj), statusMap)
 	}
 

pkg/health/statusMap.yaml

@@ -21,7 +21,6 @@ Certificate:
         ConfigError:
           ready: true
           health: unhealthy
-
 CertificateRequest:
   conditions:
     InvalidRequest:
@@ -40,21 +39,20 @@ CertificateRequest:
           status: Issuing
         Failed:
           ready: true
-
   status:
     acme:
       order:
         url: https://acme-v02.api.letsencrypt.org/acme/order/45250083/316944902
     conditions:
-      - lastTransitionTime: "2019-02-15T18:21:10Z"
+      - lastTransitionTime: '2019-02-15T18:21:10Z'
         message: Order validated
         reason: OrderValidated
-        status: "False"
+        status: 'False'
         type: ValidateFailed
       - lastTransitionTime: null
         message: Certificate issued successfully
         reason: CertIssued
-        status: "True"
+        status: 'True'
         type: Ready
 
 Deployment:
@@ -180,3 +178,36 @@ source.toolkit.fluxcd.io/v1beta1/Bucket: *flux
 image.toolkit.fluxcd.io/v1beta2/ImagePolicy: *flux
 image.toolkit.fluxcd.io/v1beta2/ImageRepository: *flux
 image.toolkit.fluxcd.io/v1beta2/ImageUpdateAutomation: *flux
+
+# Not an actual kind.
+crossplane.io:
+  conditions:
+    Ready:
+      reasons:
+        Available:
+          ready: true
+          health: healthy
+        Unavailble:
+          health: unhealthy
+          ready: true
+        Creating:
+          health: unknown
+          ready: false
+        Deleting:
+          health: unhealthy
+          ready: false
+    AsyncOperation:
+      reasons:
+        Finished:
+          ready: true
+        Ongoing:
+          ready: false
+    LastAsyncOperation:
+    Synced:
+      reasons:
+        ReconcileSuccess:
+          ready: true
+        ReconcileError:
+          health: unhealthy
+        ReconcilePaused:
+          ready: false

pkg/health/testdata/crossplane.yaml

@@ -0,0 +1,49 @@
+apiVersion: apiextensions.crossplane.io/v1
+kind: CompositeResourceDefinition
+metadata:
+  name: xpostgresqlinstances.database.example.org
+spec:
+  group: database.example.org
+  names:
+    kind: XPostgreSQLInstance
+    plural: xpostgresqlinstances
+  claimNames:
+    kind: PostgreSQLInstance
+    plural: postgresqlinstances
+  versions:
+    - name: v1alpha1
+      served: true
+      referenceable: true
+      schema:
+        openAPIV3Schema:
+          type: object
+          properties:
+            spec:
+              type: object
+              properties:
+                parameters:
+                  type: object
+                  properties:
+                    storageGB:
+                      type: integer
+                  required:
+                    - storageGB
+              required:
+                - parameters
+status:
+  conditions:
+    - type: Ready
+      reason: Available
+      status: 'True'
+    - type: Synced
+      reason: ReconcileSuccess
+      status: 'True'
+    - type: LastAsyncOperation
+      reason: ApplyFailure
+      status: 'False'
+      message: 'apply failed: an existing
+        `high_availability.0.standby_availability_zone` can only be changed when
+        exchanged with the zone specified in `zone`: '
+    - type: AsyncOperation
+      reason: Finished
+      status: 'True'