Merge pull request #1842 from vonhutrong/feature/define-image-pull-se…

…crets chart: add possibility for defining image pull secrets in daemonset
flannel-io · Dec 21, 2023 · d3007fc · d3007fc
2 parents 2ebe663 + c59f73a
commit d3007fc
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/chart/kube-flannel/templates/daemonset.yaml b/chart/kube-flannel/templates/daemonset.yaml
@@ -107,3 +107,6 @@ spec:
         hostPath:
           path: /run/xtables.lock
           type: FileOrCreate
+      {{- if .Values.global.imagePullSecrets }}
+      imagePullSecrets: {{ toYaml .Values.global.imagePullSecrets | nindent 6 }}
+      {{- end }}
diff --git a/chart/kube-flannel/tests/daemonset_test.yaml b/chart/kube-flannel/tests/daemonset_test.yaml
@@ -45,3 +45,13 @@ tests:
             - "/opt/bin/flanneld"
             - "--ip-masq"
             - "--kube-subnet-mgr"
+
+  - it: should have the correct image pull secrets
+    set:
+      global.imagePullSecrets:
+        - name: "a-test-secret"
+    asserts:
+      - equal:
+          path: spec.template.spec.imagePullSecrets
+          value:
+            - name: "a-test-secret"
diff --git a/chart/kube-flannel/values.yaml b/chart/kube-flannel/values.yaml
@@ -1,4 +1,7 @@
 ---
+global:
+  imagePullSecrets:
+# - name: "a-secret-name"
 
 # The IPv4 cidr pool to create on startup if none exists. Pod IPs will be
 # chosen from this range.