Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close aiohttp client session on cog unload #235

Merged
merged 2 commits into from
Aug 24, 2024
Merged

Close aiohttp client session on cog unload #235

merged 2 commits into from
Aug 24, 2024

Conversation

mellow-org
Copy link
Contributor

  • Close the aiohttp client session on cog_unload to avoid unclosed session errors on red_shutdown.
  • Added type hinting in the f1 cog class __init__ method.
  • Ran pre-commit hooks on all files.

@flaree
Copy link
Owner

flaree commented Aug 24, 2024

Thanks for the PR!

@flaree flaree merged commit 750502d into flaree:master Aug 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mellow-org @flaree